Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove xentropy from pypi #86

Merged
merged 4 commits into from
May 10, 2023
Merged

Remove xentropy from pypi #86

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23a4333
add sed
mvpatel2000 May 9, 2023
f61b860
disable lint
mvpatel2000 May 9, 2023
6f1bc63
fix version
mvpatel2000 May 10, 2023
1c63176
fix version
mvpatel2000 May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ jobs:
PYPI_PACKAGE_NAME="llm-foundry-test-$(date +%Y%m%d%H%M%S)"
fi

# Remove the xentropy-cuda-lib dependency as PyPI does not support direct installs. The
mvpatel2000 marked this conversation as resolved.
Show resolved Hide resolved
# error message for importing FusedCrossEntropy gives instructions on how to install if a
# user tries to use it without this dependency.
sed '/xentropy-cuda-lib@git+https:\/\/github.com\/HazyResearch\/flash-attention.git@v0.2.8#subdirectory=csrc\/xentropy/d' -i setup.py
mvpatel2000 marked this conversation as resolved.
Show resolved Hide resolved

python -m pip install --upgrade build twine
python -m build
twine check --strict dist/*
Expand Down
4 changes: 3 additions & 1 deletion llmfoundry/models/mpt/modeling_mpt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,9 @@ def __init__(
self.loss_fn = FusedCrossEntropyLoss(ignore_index=-100)
except:
raise ValueError(
'Fused Cross Entropy is not installed. Either (1) have a CUDA-compatible GPU and `pip install .[gpu]`, or (2) set your config model.loss_fn=torch_crossentropy.'
'Fused Cross Entropy is not installed. Either (1) have a CUDA-compatible GPU '
'and `pip install .[gpu]` if installing from source or `pip install xentropy-cuda-lib@git+https://github.com/HazyResearch/flash-attention.git@v0.2.8#subdirectory=csrc/xentropy` '
'if installing from pypi, or (2) set your config model.loss_fn=torch_crossentropy.'
)
elif loss_fn_config == 'torch_crossentropy':
self.loss_fn = nn.CrossEntropyLoss(ignore_index=-100)
Expand Down