Change .getMime to .detect
#38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was done for a couple of reasons. As features have been added to WASMagic, the method name `.getMime` is no longer accurate. The user can get any number of available features from the passed `Buffer`. Second, consistency. Several other `libmagic` based libraries used the `.detect` method (though the signatures differ). While on the surface this looks like a BREAKING CHANGE, it is not. The original `.getMime` method passes through to `.detect`. Though, it has been marked as deprecated.
moshen
added a commit
that referenced
this pull request
Feb 25, 2024
This was done for a couple of reasons. As features have been added to WASMagic, the method name `.getMime` is no longer accurate. The user can get any number of available features from the passed `Buffer`. Second, consistency. Several other `libmagic` based libraries used the `.detect` method (though the signatures differ). While on the surface this looks like a BREAKING CHANGE, it is not. The original `.getMime` method passes through to `.detect`. Though, it has been marked as deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done for a couple of reasons. As features have been added to WASMagic, the method name
.getMimeis no longer accurate. The user can get any number of available features from the passedBuffer. Second, consistency. Several otherlibmagicbased libraries used the.detectmethod (though the signatures differ).While on the surface this looks like a BREAKING CHANGE, it is not. The original
.getMimemethod passes through to.detect. Though, it has been marked as deprecated.