Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change .getMime to .detect #38

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Commits on Feb 19, 2024

  1. Change .getMime to .detect

    This was done for a couple of reasons. As features have been added to
    WASMagic, the method name `.getMime` is no longer accurate. The user
    can get any number of available features from the passed `Buffer`.
    Second, consistency. Several other `libmagic` based libraries used the
    `.detect` method (though the signatures differ).
    
    While on the surface this looks like a BREAKING CHANGE, it is not. The
    original `.getMime` method passes through to `.detect`. Though, it has
    been marked as deprecated.
    moshen committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    ce6dcd9 View commit details
    Browse the repository at this point in the history