Fix Rviz argument in demo_gazebo.launch #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name of the launch argument in the invoked launch file is `rviz_config` but is incorrectly called as `config`here. This fix was already merged with `demo.launch` but was missed for this file.
|
Thanks for helping in improving MoveIt and open source robotics! |
jschleicher
suggested changes
Dec 2, 2019
moveit_setup_assistant/templates/moveit_config_pkg_template/launch/demo_gazebo.launch
Outdated
Show resolved
Hide resolved
…unch/demo_gazebo.launch The new argument requires a config file instead of boolean value. See moveit#1397. Co-Authored-By: jschleicher <j.schleicher@pilz.de>
Codecov Report
@@ Coverage Diff @@
## master #1797 +/- ##
==========================================
+ Coverage 47.5% 47.58% +0.07%
==========================================
Files 290 290
Lines 22948 22950 +2
==========================================
+ Hits 10901 10920 +19
+ Misses 12047 12030 -17
Continue to review full report at Codecov.
|
rhaschke
approved these changes
Dec 18, 2019
|
Congrats on getting your first MoveIt pull request merged and improving open source robotics! |
v4hn
pushed a commit
to v4hn/moveit
that referenced
this pull request
Mar 30, 2020
* rename config -> rviz_config * replace boolean value with file location (as in demo.launch)
v4hn
pushed a commit
to v4hn/moveit
that referenced
this pull request
Mar 31, 2020
* rename config -> rviz_config * replace boolean value with file location (as in demo.launch)
v4hn
pushed a commit
to v4hn/moveit
that referenced
this pull request
Mar 31, 2020
* rename config -> rviz_config * replace boolean value with file location (as in demo.launch)
sjahr
pushed a commit
to sjahr/moveit
that referenced
this pull request
Jun 21, 2024
…eit#1797) * fix: resolve bugs in MoveGroupSequenceAction class * style: adopt .clang-format Co-authored-by: Marco Magri <marco.magri@fraunhofer.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The name of the launch argument in the invoked launch file
moveit_rviz.launchisrviz_configbut is incorrectly called asconfighere. This fix was already merged withdemo.launchbut was missed for this file.Simply launching this launch file now throws the unused args error.
Checklist