Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle move_group_capabilities #2694

Open
forrest-rm opened this issue Feb 19, 2024 · 3 comments
Open

Properly handle move_group_capabilities #2694

forrest-rm opened this issue Feb 19, 2024 · 3 comments
Labels
enhancement New feature or request persistent Allows issues to remain open without automatic stalling and closing.

Comments

@forrest-rm
Copy link
Contributor

Description

In moveit_configs_utils/moveit_configs_utils/launches.py, the capabilities parameter is handled separately instead as part of moveit_config.to_dict() like the other moveit_config parameters.

Environment

  • ROS Distro: Humble, but also present in other distros
  • OS Version: Ubuntu 22.04
  • humble and main source branches

Steps to reproduce

A temporary fix was made in PR: #2587
@sjahr suggested creating an issue for a more integrated fix

@forrest-rm forrest-rm added the bug Something isn't working label Feb 19, 2024
@henningkayser henningkayser added enhancement New feature or request and removed bug Something isn't working labels Feb 27, 2024
Copy link

This issue is being labeled as stale because it has been open 45 days with no activity. It will be automatically closed after another 45 days without follow-ups.

@github-actions github-actions bot added the stale Inactive issues and PRs are marked as stale and may be closed automatically. label Apr 12, 2024
@sjahr sjahr added persistent Allows issues to remain open without automatic stalling and closing. and removed stale Inactive issues and PRs are marked as stale and may be closed automatically. labels Apr 12, 2024
@gavanderhoorn
Copy link
Member

gavanderhoorn commented Jun 5, 2024

@sjahr / @henningkayser: could you please summarise the status of this issue?

With configuration packages generated by the MSA from main (bee0a29) we're seeing #2734 here, which I believe is related to this one, and is somewhat confusing.

I'd like to avoid approaches like this one, as it would mean maintaining yet another fork.


Edit: @SyZbidi FYI

@mikeferguson
Copy link
Contributor

I've opened #3018 to fix the current issues that make the exported MSA config not actually run

From what I can see, we can't actually use the moveit_config.to_dict() unless we drop support for the launch parameters capabilities/disabled_capabilities (which I have no idea how widely the are used).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request persistent Allows issues to remain open without automatic stalling and closing.
Projects
None yet
Development

No branches or pull requests

5 participants