Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix move_group_capabilities usage #3018

Merged
merged 5 commits into from
Oct 14, 2024
Merged

fix move_group_capabilities usage #3018

merged 5 commits into from
Oct 14, 2024

Conversation

mikeferguson
Copy link
Contributor

Description

  • this fixes an issue seen when no capabilities are defined (Launch Error #2734)
  • also adds ability to specify "disabled_capabilities" in the moveit_config

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@mikeferguson
fix move_group_capabilities usage
d864d9c 
* this fixes an issue seen when no capabilities are defined (moveit#2734)
* also adds ability to specify disabled capabilities
This was referenced Oct 2, 2024
Closed
Open
@mikeferguson mikeferguson mentioned this pull request Oct 3, 2024
Closed
@sjahr sjahr merged commit 56d1ab1 into moveit:main Oct 14, 2024
10 of 13 checks passed
@mikeferguson mikeferguson added backport-humble Mergify label that triggers a PR backport to Humble backport-iron Mergify label that triggers a PR backport to Iron labels Oct 15, 2024
mergify bot pushed a commit that referenced this pull request Oct 15, 2024
@mikeferguson @mergify
fix move_group_capabilities usage (#3018)
92fce82 
(cherry picked from commit 56d1ab1)
mergify bot pushed a commit that referenced this pull request Oct 15, 2024
@mikeferguson @mergify
fix move_group_capabilities usage (#3018)
6a1d217 
(cherry picked from commit 56d1ab1)
This was referenced Oct 15, 2024
Merged
Open
@mikeferguson mikeferguson deleted the capabilities branch October 15, 2024 13:58
sjahr pushed a commit that referenced this pull request Oct 16, 2024
@mergify @mikeferguson
fix move_group_capabilities usage (#3018) (#3033)
ccd3103 
(cherry picked from commit 56d1ab1)

Co-authored-by: Michael Ferguson <mfergs7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjahr sjahr sjahr approved these changes

Assignees
No one assigned
Labels
backport-humble Mergify label that triggers a PR backport to Humble backport-iron Mergify label that triggers a PR backport to Iron
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeferguson @sjahr