Simplify controller manager namespacing #2210
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to simplify the logic with setting a namespace (stored in the
ns_
variable) for Ros2Control Manager.My understanding of the original logic:
ns_
can be set via constructor, but its value is ignored and replaced by the parameter value.ns_
to match.ns_
is not set via constructor, we try to get it from a parameter.ns_
remains an empty string.It sounds like the desired behaviour would be to set
ns_
to the value of theros_control_namespace
parameter, if it exists, or otherwise default to "/", without considering the original value ofns_
.This PR also adds a deprecation notice to setting
ns_
via constructor, since this value is ignored anyway. I've deprecated it instead of removing it outright to be safe, but I'm not sure that this is used anywhere, given that this is used as a plugin and thus should be default constructed.