Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Servo] Add additional info about twist frame conversion #2295

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

ibrahiminfinite
Copy link
Contributor

@ibrahiminfinite ibrahiminfinite commented Aug 11, 2023

Description

This PR adds some info for the users about the limitations of twist frame conversion currently used in Servo.

Checklist

Ping : @AndyZe @sea-bass

Co-authored-by: AndyZe <andyz@utexas.edu>
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.03% 🎉

Comparison is base (92ca89d) 50.69% compared to head (2a88f62) 50.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2295      +/-   ##
==========================================
+ Coverage   50.69%   50.71%   +0.03%     
==========================================
  Files         386      386              
  Lines       31912    31914       +2     
==========================================
+ Hits        16174    16182       +8     
+ Misses      15738    15732       -6     
Files Changed Coverage Δ
moveit_ros/moveit_servo/src/servo.cpp 66.13% <50.00%> (-0.13%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndyZe AndyZe enabled auto-merge (squash) August 11, 2023 15:52
@AndyZe AndyZe merged commit 4476fb6 into moveit:main Aug 11, 2023
7 of 8 checks passed
@ibrahiminfinite ibrahiminfinite deleted the add_info branch February 24, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants