-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix class_loader warnings in pilz unit tests #2296
Merged
henningkayser
merged 2 commits into
moveit:main
from
todoubaba:fix_class_loader_warning
Aug 15, 2023
Merged
Fix class_loader warnings in pilz unit tests #2296
henningkayser
merged 2 commits into
moveit:main
from
todoubaba:fix_class_loader_warning
Aug 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todoubaba
changed the title
Fx class_loader warnings in pilz unit tests
Fix class_loader warnings in pilz unit tests
Aug 12, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2296 +/- ##
==========================================
- Coverage 50.72% 50.71% -0.00%
==========================================
Files 386 386
Lines 31914 31914
==========================================
- Hits 16184 16181 -3
- Misses 15730 15733 +3 ☔ View full report in Codecov by Sentry. |
sjahr
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for providing this fix!
henningkayser
approved these changes
Aug 15, 2023
henningkayser
added
backport-iron
Mergify label that triggers a PR backport to Iron
backport-humble
Mergify label that triggers a PR backport to Humble
labels
Aug 15, 2023
mergify bot
pushed a commit
that referenced
this pull request
Aug 15, 2023
(cherry picked from commit d4dcea3)
mergify bot
pushed a commit
that referenced
this pull request
Aug 15, 2023
(cherry picked from commit d4dcea3)
This was referenced Aug 15, 2023
sjahr
pushed a commit
that referenced
this pull request
Aug 16, 2023
sjahr
pushed a commit
that referenced
this pull request
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-humble
Mergify label that triggers a PR backport to Humble
backport-iron
Mergify label that triggers a PR backport to Iron
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running pilz unit tests, class_loader reports the following warning:
Checklist