Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix class_loader warnings in pilz unit tests #2296

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Fix class_loader warnings in pilz unit tests #2296

merged 2 commits into from
Aug 15, 2023

Conversation

todoubaba
Copy link
Contributor

@todoubaba todoubaba commented Aug 12, 2023

Description

When running pilz unit tests, class_loader reports the following warning:

Warning: class_loader.ClassLoader: SEVERE WARNING!!! Attempting to unload library while objects created by this loader exist in the heap! You should delete your objects before attempting to unload the library or destroying the ClassLoader. The library will NOT be unloaded.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@todoubaba todoubaba changed the title Fx class_loader warnings in pilz unit tests Fix class_loader warnings in pilz unit tests Aug 12, 2023
@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4476fb6) 50.72% compared to head (700fbbb) 50.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2296      +/-   ##
==========================================
- Coverage   50.72%   50.71%   -0.00%     
==========================================
  Files         386      386              
  Lines       31914    31914              
==========================================
- Hits        16184    16181       -3     
- Misses      15730    15733       +3     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing this fix!

@henningkayser henningkayser added backport-iron Mergify label that triggers a PR backport to Iron backport-humble Mergify label that triggers a PR backport to Humble labels Aug 15, 2023
@henningkayser henningkayser merged commit d4dcea3 into moveit:main Aug 15, 2023
8 checks passed
mergify bot pushed a commit that referenced this pull request Aug 15, 2023
mergify bot pushed a commit that referenced this pull request Aug 15, 2023
sjahr pushed a commit that referenced this pull request Aug 16, 2023
(cherry picked from commit d4dcea3)

Co-authored-by: Yang Lin <todoubaba@gmail.com>
sjahr pushed a commit that referenced this pull request Aug 16, 2023
(cherry picked from commit d4dcea3)

Co-authored-by: Yang Lin <todoubaba@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble Mergify label that triggers a PR backport to Humble backport-iron Mergify label that triggers a PR backport to Iron
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants