Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source install of gtest branch in CI (backport #2284) #2313

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 22, 2023

This is an automatic backport of pull request #2284 done by Mergify.
Cherry-pick of f9f1804 has failed:

On branch mergify/bp/iron/pr-2284
Your branch is up to date with 'origin/iron'.

You are currently cherry-picking commit f9f180471.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/ci.yaml

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

The PR branch has been removed by GitHub so that CI was using the
official release. The compile warnings have been fixed in a
more recent version.

(cherry picked from commit f9f1804)

# Conflicts:
#	.github/workflows/ci.yaml
@mergify mergify bot added the conflicts label Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1955e57) 50.50% compared to head (1955e57) 50.50%.

❗ Current head 1955e57 differs from pull request most recent head edf5581. Consider uploading reports for the commit edf5581 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             iron    #2313   +/-   ##
=======================================
  Coverage   50.50%   50.50%           
=======================================
  Files         386      386           
  Lines       31732    31732           
=======================================
  Hits        16022    16022           
  Misses      15710    15710           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henningkayser
Copy link
Member

this needs to be merged for CI to succeed

@henningkayser henningkayser merged commit 93c48b0 into iron Aug 22, 2023
4 of 6 checks passed
@henningkayser henningkayser deleted the mergify/bp/iron/pr-2284 branch August 22, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant