Use find_package for fcl #2399
Merged
Use find_package for fcl #2399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerjw
added
the
backport-humble
8 tasks
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2399 +/- ##
==========================================
- Coverage 50.85% 50.36% -0.49%
==========================================
Files 386 385 -1
Lines 31943 31772 -171
==========================================
- Hits 16242 15998 -244
- Misses 15701 15774 +73 ☔ View full report in Codecov by Sentry. |
tylerjw
force-pushed
the
find_package_fcl
branch
from
51c047b to
38348d2
Compare
mergify bot
pushed a commit
that referenced
this pull request
Sep 29, 2023
(cherry picked from commit 498a9f3) # Conflicts: # moveit_core/CMakeLists.txt
m-elwin
pushed a commit
to m-elwin/moveit2
that referenced
this pull request
Dec 4, 2023
JeisonUR
added a commit
to Unlimited-Robotics/moveit2
that referenced
this pull request
Dec 29, 2023
This reverts commit b41628a.
traversaro
added a commit
to sonelu/ros-humble
that referenced
this pull request
Nov 28, 2024
It was superseded by moveit/moveit2#2399 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The version of fcl we use has a find module. We should just use it.
See #2391