Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to get for Dict lookup to prevent KeyError #3043

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Switch to get for Dict lookup to prevent KeyError #3043

merged 1 commit into from
Oct 27, 2024

Conversation

brendandburns
Copy link
Contributor

@brendandburns brendandburns commented Oct 27, 2024 •
edited
Loading

Description

If you run the default generated configs for MoveIt on a headless system where DISPLAY isn't defined in the environment, this code crashes with a KeyError. Switch to use dict.get(DISPLAY, "") which returns "" instead of
throwing.

Checklist

mikeferguson
mikeferguson approved these changes Oct 27, 2024
View reviewed changes
Copy link
Contributor

@mikeferguson mikeferguson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I've actually run into this issue previously

@mikeferguson mikeferguson added this pull request to the merge queue Oct 27, 2024
Merged via the queue into moveit:main with commit d2ab1b6 Oct 27, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeferguson mikeferguson mikeferguson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brendandburns @mikeferguson