Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port fixes for handling orientation constraints #3052

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Commits on Oct 31, 2024

  1. PoseModelStateSpace: Reintroduce Cartesian interpolation

    The problem with potential jumps due to Cartesian interpolation in principle remains, which is a dilemma of the current design:
    
    - We do need Cartesian interpolation to reduce the risk of state rejection due to a failing path constraint, which currently cannot be checked during interpolation.
    - Ideally, we would do joint interpolation and only resort to Cartesian interpolation if the path constraint is violated, i.e. follow a similar approach as in #3618. However, this would require access to the path constraint...
    rhaschke committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    5cc65c2 View commit details
    Browse the repository at this point in the history
  2. Fix orientation constraints

    The tolerance of orientation constraints needs to be interpreted w.r.t. the given frame_id of the constraint instead of the target frame. Not doing so, a large tolerance is interpreted about the wrong axis and resolving constraint frames fails.
    Unfortunately, the proposed approach only works for the ROTATION_VECTOR representation.
    rhaschke committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    7f0fa73 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Address review

    rhaschke committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    793f2d1 View commit details
    Browse the repository at this point in the history