Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source build of generate_parameter_library on Humble #3079

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

sea-bass
Copy link
Contributor

Description

This change was formerly needed (and reverted on main), but not in the Humble branch.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sea-bass sea-bass requested review from pac48, rhaschke and sjahr November 11, 2024 13:07
Copy link

mergify bot commented Nov 11, 2024

Please target the main branch for development, we will backport the changes to humble for you if approved and if they don't break API.

@sea-bass
Copy link
Contributor Author

sea-bass commented Nov 11, 2024

Seems like a PSM unit tests segfaulted here in both Humble jobs...?

EDIT: Re-ran and it passed 🤷🏻

@sea-bass sea-bass enabled auto-merge (squash) November 11, 2024 15:03
@sea-bass sea-bass merged commit 0179460 into humble Nov 11, 2024
9 of 10 checks passed
@sea-bass sea-bass deleted the remove-gen-param-repos-file-humble branch November 11, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants