-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow RobotState::setFromIK to work with subframes (backport #3077) #3085
Conversation
* Adds regression tests for setFromIK with objects. Adds failing tests demonstrating failure with subframes * Modifies RobotState::setFromIK to account for subframes * Fixes formatting * Fixes formatting * Fixes formatting * Applies PR suggestions * Applies PR comments --------- Co-authored-by: Tom Noble <tom@rivelinrobotics.com> Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai> (cherry picked from commit ab34495) # Conflicts: # moveit_core/robot_state/src/robot_state.cpp
Cherry-pick of ab34495 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
@rr-tom-noble sadly this one has conflicts too -- would you like to take a look? Thanks! |
Co-authored-by: Tom Noble <tom@rivelinrobotics.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work!
Though @rr-tom-noble you said you were running into other issues? Is this just related to mixing source/binary installs but should be good pending that resolution?
@sea-bass Given the tests, I'm confident that attaching objects & subframes through the Our in-practice use case a bit more complicated and involves using planning scene services to load and attach objects. It could be related to our mix of and binary and source, but my gut feel is that Given that issue arises from a somewhat different use-case, I think I'm happy with this PR as is, though I'm happy to leave it up to your discretion. I'll be looking into the next issue shortly. |
@sea-bass I believe the failure is unrelated. I've seen it sporadically on a few other PRs |
Description
Fixes #3072
RobotState
cansetFromIK
with a collision objectRobotState
cannotsetFromIK
with a subframeRobotState::setFromIK
to consider subframesI tried adding the tests directly to the robot state tests, however, I was getting issues with no kinematic solver being associated with the planning group of the
OneRobot
fixture.Pilz already had a test which was checking
setFromIK
, and appears to be setup with a kinematic solver, so I've added the tests there.Checklist
This is an automatic backport of pull request #3077 done by [Mergify](https://mergify.com).