Fix logic in CheckStartStateBounds adapter (backport #3143) #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Fix logic in CheckStartStateBoundsAdapter * Explicit fallthrough * Fix switch statement and add basic test scaffolding * Remove extra variable * Fix logic and add tests for continuous joints * Validate changed start state * Appeasing our Lord and Savior clang-tidy * Update status message (cherry picked from commit f82cdcd)
sea-bass
approved these changes
Dec 4, 2024
mikeferguson
approved these changes
Dec 4, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## jazzy #3148 +/- ##
========================================
Coverage ? 45.75%
========================================
Files ? 482
Lines ? 40431
Branches ? 0
========================================
Hits ? 18495
Misses ? 21936
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix the logic in the
CheckStartStateBoundsadapter, as @chama1176 pointed out.It also adds some basic unit tests to prevent further breakages and maintain expected behavior.
Closes #2924
Checklist
This is an automatic backport of pull request #3143 done by [Mergify](https://mergify.com).