Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-879] Add const specifier to moveit_core #3202

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

GayarUsmanov
Copy link
Contributor

@GayarUsmanov GayarUsmanov commented Jan 7, 2025

Description

This PR adds const specifiers to methods of some classes in moveit_core subdir as proposed in #879.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@GayarUsmanov GayarUsmanov changed the title gayar/issue 879 [Issue-879] Add const specifier to moveit_core Jan 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.64%. Comparing base (75286c7) to head (f17c57a).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...lude/moveit/robot_state/cartesian_interpolator.hpp 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3202      +/-   ##
==========================================
- Coverage   46.01%   45.64%   -0.37%     
==========================================
  Files         714      714              
  Lines       62304    62282      -22     
  Branches     7532     7529       -3     
==========================================
- Hits        28666    28421     -245     
- Misses      33471    33694     +223     
  Partials      167      167              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass
Copy link
Contributor

sea-bass commented Jan 7, 2025

Just one formatting failure, but otherwise looks good

@GayarUsmanov GayarUsmanov force-pushed the gayar/issue-879 branch 2 times, most recently from 57a6175 to f300681 Compare January 7, 2025 19:27
@GayarUsmanov GayarUsmanov marked this pull request as ready for review January 7, 2025 19:27
@GayarUsmanov
Copy link
Contributor Author

GayarUsmanov commented Jan 7, 2025

Just one formatting failure, but otherwise looks good

Thanks for pointing it out. Fixed.

Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sjahr sjahr added this pull request to the merge queue Jan 9, 2025
Merged via the queue into moveit:main with commit 932c192 Jan 9, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants