Remove recommendation for Cyclone due to FastDDS issues #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henningkayser
added
the
backport-humble
This comment was marked as resolved.
This comment was marked as resolved.
henningkayser
force-pushed
the
pr-remove_cyclone_recommendation
branch
from
2805261 to
a0d26d5
Compare
sea-bass
reviewed
Oct 25, 2023
|
I agree with @sea-bass but it would probably be best if we always check against both right? |
We should check both, but probably it makes more sense to do this in the moveit2 repo, running our actual tests. |
tylerjw
force-pushed
the
pr-remove_cyclone_recommendation
branch
from
6855ee7 to
d62c680
Compare
sjahr
approved these changes
Oct 30, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
* Remove recommendation for Cyclone due to FastDDS issues * Remove cyclone config from Dockerfile (cherry picked from commit 71ee840) # Conflicts: # doc/tutorials/getting_started/getting_started.rst # doc/tutorials/quickstart_in_rviz/quickstart_in_rviz_tutorial.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have any open issues with FastDDS anymore, everything is running fine per our knowledge. Let's remove this recommendation.