visualization improvements #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In realtime mode, rviz display stopped with the last waypoint and didn't show the final scene.
automatically remove TaskPanel when last TaskDisplay is closed
|
merged |
|
great to see that issue resolved, thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains a series of little bug fixes to rviz visualization.
Particularly,
TaskPanelsettings are all saved now.Unfortunately, due to a bug in rviz (addressed in ros-visualization/rviz#1303),
programmatically created panels cannot save their settings. If the rviz patch is merged, I have one more commit to actually use the new feature.
As a workaround for now, one first needs to create a new task panel before creating any task display using rviz' create panel mechanism. The created panel will save it's settings and serve as the singleton instance.