[WIP] Python API #99
Merged
[WIP] Python API #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Class holder needs to be a smart pointer, e.g. std::auto_ptr. This can be released(), such that ownership can be passed. Further, derived types need to be declared as implicitly_convertible to base type.
catkin package expects all includes to be in one global location
... to become compatible with classical pybind11 modules, e.g. the MoveIt packages
Using template names T is not a good idea, because this name is used verbatim for some error reporting, resulting e.g. in: Tried to call pure virtual function "T::canCompute"
rhaschke
force-pushed
the
wip-python-api
branch
3 times, most recently
from
aa136dd to
9487d7e
Compare
If MoveIt and MTC use incompatible versions of pybind11, the tests will fail because MoveIt objects like RobotModel or PlanningScene cannot be passed to MTC objects and vice versa.
rhaschke
force-pushed
the
wip-python-api
branch
2 times, most recently
from
b28075d to
5943dcd
Compare
rhaschke
added a commit
to ubi-agni/moveit_task_constructor
that referenced
this pull request
Nov 19, 2022
... based on pybind11
rhaschke
added a commit
to ubi-agni/moveit_task_constructor
that referenced
this pull request
Nov 19, 2022
... based on pybind11
rhaschke
added a commit
to ubi-agni/moveit_task_constructor
that referenced
this pull request
Nov 22, 2022
... based on pybind11
rhaschke
added a commit
to ubi-agni/moveit_task_constructor
that referenced
this pull request
Nov 22, 2022
... based on pybind11
rhaschke
added a commit
to ubi-agni/moveit_task_constructor
that referenced
this pull request
Nov 22, 2022
... based on pybind11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a draft PR to collect TODOs and make the existing Python API visible somehow.
Major issues:
boost::pythondoesn't supportstd::unique_ptrforcing us to use deprecatedstd::auto_ptr.