Ignore plural cases of units for now #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[This PR](unicode-org/cldr#474) added information about cases for pluralization of units. This code was not ready for that, and started returning whichever happened to be that last case in the section. For now, we'll just return the case-less version as we always did.
movermeyer
force-pushed
the
mo.ignore_plural_cases
branch
from
7298a7a
to
fea3aab
Compare
cejaekl
approved these changes
Aug 30, 2021
trishrempel
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Ref: ruby-i18n#67
This PR added information about cases for pluralization of units.
This code was not ready for that, and started returning whichever happened to be that last case in the section.
What approach did you choose and why?
For now, we'll just return the case-less version as we always did.
What should reviewers focus on?
...
The impact of these changes
We now return the same values for these strings that we did in version v37
Testing
Checklist