Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dot at the end of chat lines during model replies to make the responses look smoother. #262

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

Guocork
Copy link
Collaborator

@Guocork Guocork commented Sep 27, 2024

There is a problem: Sometimes Makepad cannot immediately render this dot.

src/chat/chat_line.rs Outdated Show resolved Hide resolved
@joulei
Copy link
Collaborator

joulei commented Sep 30, 2024

@Guocork thanks for the PR
I'm investigating why Makepad cannot sometimes can't render the character

@joulei
Copy link
Collaborator

joulei commented Oct 8, 2024

@jmbejar we confirmed that the rendering issue with the special character only happens in Linux.
Are you ok with merging this as-is, while we open the issue in Makepad?

@joulei joulei requested a review from jmbejar October 24, 2024 07:52
@joulei joulei merged commit b01857b into moxin-org:dev Nov 18, 2024
5 checks passed
@Guocork Guocork deleted the fixed-issue-255 branch November 18, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants