Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dot at the end of chat lines during model replies to make the responses look smoother. #262

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Add a dot at the end of chat lines during model replies to make the responses look smoother. #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36e2367
add dot at the end of chatline
Guocork Sep 27, 2024
a5ecc6b
delete pub of the State
Guocork Sep 27, 2024
c668b0b
move the arm back
Guocork Sep 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/chat/chat_line.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,16 +415,24 @@ impl ChatLineRef {
inner.label(id!(avatar_label)).set_text(text);
}

pub fn set_message_text(&mut self, cx: &mut Cx, text: &str) {
pub fn set_message_text(&mut self, cx: &mut Cx, text: &str, is_streaming: bool) {
let Some(mut inner) = self.borrow_mut() else {
return;
};

match inner.edition_state {

ChatLineState::Editable | ChatLineState::NotEditable => {
inner.text_input(id!(input)).set_text(text.trim());
inner.label(id!(plain_text_message)).set_text(text.trim());
inner.markdown(id!(markdown_message)).set_text(text.trim());
if is_streaming && !text.is_empty() {
let output = format!("{}{}", text, "●");
inner.text_input(id!(input)).set_text(&output.trim());
inner.label(id!(plain_text_message)).set_text(&output.trim());
inner.markdown(id!(markdown_message)).set_text(&output.trim());
} else {
inner.text_input(id!(input)).set_text(text.trim());
inner.label(id!(plain_text_message)).set_text(text.trim());
inner.markdown(id!(markdown_message)).set_text(text.trim());
}

// We know only AI assistant messages could be empty, so it is never
// displayed in user's chat lines.
Expand Down
3 changes: 2 additions & 1 deletion src/chat/chat_panel.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,7 +882,6 @@ impl ChatPanel {
chat_line_item.set_regenerate_button_visible(true);
};

chat_line_item.set_message_text(cx, &chat_line_data.content);
chat_line_item.set_message_id(chat_line_data.id);

// Disable actions for the last chat line when model is streaming
Expand All @@ -894,8 +893,10 @@ impl ChatPanel {
}
) && item_id == messages_count - 1
{
chat_line_item.set_message_text(cx, &chat_line_data.content, true);
chat_line_item.set_actions_enabled(cx, false);
} else {
chat_line_item.set_message_text(cx, &chat_line_data.content, false);
chat_line_item.set_actions_enabled(cx, true);
}

Expand Down
Loading