Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treestatus: check for user authentication before require_auth0 API calls (Bug 1896642) #203

Merged
merged 2 commits into from
May 14, 2024
Merged

treestatus: check for user authentication before require_auth0 API calls (Bug 1896642) #203

merged 2 commits into from
May 14, 2024

Commits on May 14, 2024

  1. treestatus: check for user authentication before require_auth0 API … 

    …calls (Bug 1896642)

In other parts of Lando, before making an API call that uses
the `require_auth0` kwarg, we do an explicit check that the
user is authenticated and handle unauthenticated requests
appropriately. This was overlooked in implementing the Treestatus
UI and is resulting in errors in Sentry since we instead
only discover the missing credentials when making the request,
resulting in an unhandled exception. Add an explicit check
to each handler which makes an `auth0_required` API call.
    @cgsheeh
    cgsheeh committed May 14, 2024
    Configuration menu
    Copy the full SHA
    c03dd8a View commit details
    Browse the repository at this point in the history

  2. 401 codes when auth fails

    @cgsheeh
    cgsheeh committed May 14, 2024
    Configuration menu
    Copy the full SHA
    8a592c4 View commit details
    Browse the repository at this point in the history