treestatus: convert logging of Treestatus API errors to info level (Bug 1897044)
#204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(Bug 1897044) The `error` and `exception` level logging calls cause Sentry to treat expected states as new issues. Lower the level to `info` to quiet down Sentry. Issues experienced by the Treestatus API will still show up in the LandoAPI logs, and at the `info` level we can still debug which code paths are taken by various requests.
zzzeid
requested changes
May 16, 2024
landoui/treestatus.py
Outdated
| @@ -227,13 +227,13 @@ def treestatus_tree(tree: str): | |||
| raise | |||
|
|
|||
| error = f"Error received from LandoAPI: {exc.detail}" | |||
| logger.error(error) | |||
| logger.info(error) | |||
There was a problem hiding this comment.
I think for this one, given that we've identified that there are lots of 404s due to spam, we should probably just return a 404 immediately (and not redirect or flash a message) in that case. Otherwise we may still be flooding the logs with useless data.
zzzeid
approved these changes
May 16, 2024
There was a problem hiding this comment.
nit: I think the abort(404) could work better for that particular instance, since we can stop the code early and we don't really know what the referrer is necessarily. I don't think it's very important in this case though, as we are porting this soon to Django.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
errorandexceptionlevel logging calls cause Sentry to treatexpected states as new issues. Lower the level to
infoto quiet downSentry. Issues experienced by the Treestatus API will still show up in
the LandoAPI logs, and at the
infolevel we can still debug whichcode paths are taken by various requests.