Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Commit

Permalink
For #12557 - Stop logging AS-places reads/writes explicit interrupts
Browse files Browse the repository at this point in the history
The OperationInterrupted exceptions are expected so logging them to the crash
servers has little use.
  • Loading branch information
Mugurell authored and mergify[bot] committed Jul 28, 2022
1 parent 40a57a0 commit 0ed5dfb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ abstract class PlacesStorage(
} catch (e: PlacesException.OperationInterrupted) {
logger.debug("Ignoring expected OperationInterrupted exception for explicit writer interrupt call", e)
} catch (e: PlacesException) {
crashReporter?.submitCaughtException(e)
logger.warn("Ignoring PlacesException while interrupting writes", e)
}
}
Expand All @@ -115,7 +114,6 @@ abstract class PlacesStorage(
} catch (e: PlacesException.OperationInterrupted) {
logger.debug("Ignoring expected OperationInterrupted exception for explicit reader interrupt call", e)
} catch (e: PlacesException) {
crashReporter?.submitCaughtException(e)
logger.warn("Ignoring PlacesException while interrupting reads", e)
}
}
Expand Down
3 changes: 3 additions & 0 deletions docs/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ permalink: /changelog/
* [Gecko](https://github.com/mozilla-mobile/android-components/blob/main/buildSrc/src/main/java/Gecko.kt)
* [Configuration](https://github.com/mozilla-mobile/android-components/blob/main/.config.yml)

* **browser-storage-sync**:
* Stop loading to the crash servers the expected `OperationInterrupted` exceptions for when interrupting in progress reads/writes from Application-Services. [#12557](https://github.com/mozilla-mobile/android-components/issues/12557)

# 104.0.0
* [Commits](https://github.com/mozilla-mobile/android-components/compare/v103.0.0...v104.0.0)
* [Milestone](https://github.com/mozilla-mobile/android-components/milestone/151?closed=1)
Expand Down

1 comment on commit 0ed5dfb

@firefoxci-taskcluster
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh! Looks like an error! Details

Failed to fetch task artifact public/github/customCheckRunText.md for GitHub integration.
Make sure the artifact exists on the worker or other location.

Please sign in to comment.