Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Commit

Permalink
For #12557 - Stop logging AS-places reads/writes explicit interrupts
Browse files Browse the repository at this point in the history
The OperationInterrupted exceptions are expected so logging them to the crash
servers has little use.

(cherry picked from commit 0ed5dfb)
  • Loading branch information
Mugurell authored and mergify[bot] committed Jul 28, 2022
1 parent 76d0bc2 commit 4ea7ba2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ abstract class PlacesStorage(
} catch (e: PlacesException.OperationInterrupted) {
logger.debug("Ignoring expected OperationInterrupted exception for explicit writer interrupt call", e)
} catch (e: PlacesException) {
crashReporter?.submitCaughtException(e)
logger.warn("Ignoring PlacesException while interrupting writes", e)
}
}
Expand All @@ -115,7 +114,6 @@ abstract class PlacesStorage(
} catch (e: PlacesException.OperationInterrupted) {
logger.debug("Ignoring expected OperationInterrupted exception for explicit reader interrupt call", e)
} catch (e: PlacesException) {
crashReporter?.submitCaughtException(e)
logger.warn("Ignoring PlacesException while interrupting reads", e)
}
}
Expand Down
3 changes: 3 additions & 0 deletions docs/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ permalink: /changelog/
* [Gecko](https://github.com/mozilla-mobile/android-components/blob/main/buildSrc/src/main/java/Gecko.kt)
* [Configuration](https://github.com/mozilla-mobile/android-components/blob/main/.config.yml)

* **browser-storage-sync**:
* Stop loading to the crash servers the expected `OperationInterrupted` exceptions for when interrupting in progress reads/writes from Application-Services. [#12557](https://github.com/mozilla-mobile/android-components/issues/12557)

* **feature-media**:
* 🚒 Bug fixed [issue #12433](https://github.com/mozilla-mobile/android-components/issues/12433) Prevent media notifications updates that would cause it to flicker or loose the action button.

Expand Down

0 comments on commit 4ea7ba2

Please sign in to comment.