Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Expand toolbar when url changes #12215

Closed
Mugurell opened this issue May 23, 2022 · 7 comments
Closed

Expand toolbar when url changes #12215

Mugurell opened this issue May 23, 2022 · 7 comments
Assignees
@indurs
Labels
<toolbar> Components: browser-toolbar, concept-toolbar

Comments

@Mugurell
Copy link
Contributor

Mugurell commented May 23, 2022 •
edited by data-sync-user
Loading

Issue seen on Firefox Focus in mozilla-mobile/focus-android#7075 as it does not have a similar listener as Fenix has for when the url or the load request changes.

This being a common usecase and a general flow we'd want to enforce for all EngineView integrators it should be handled in A-C.

┆Issue is synchronized with this Jira Task
@Mugurell Mugurell added the <toolbar> Components: browser-toolbar, concept-toolbar label May 23, 2022
@Mugurell Mugurell mentioned this issue May 23, 2022
Closed
@indurs
Copy link
Contributor

indurs commented May 26, 2022

@Mugurell , can I work on this issue?

@Mugurell
Copy link
Contributor Author

@Mugurell , can I work on this issue?

Would be great to!
While this will probably not be a breaking change both Fenix and Focus will need to be updated to remove their own code addressing this scenario. Would you want to work on that also?

@indurs
Copy link
Contributor

indurs commented May 26, 2022

Sure. I'll also update Fenix and Focus

indurs added a commit to indurs/android-components that referenced this issue May 30, 2022
@indurs @Mugurell
For mozilla-mobile#12215: Expand toolbar when url changes
5538566 
This fix allows the toolbar to be visible after the user clicks on a link and scrolls

Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
@indurs
Copy link
Contributor

indurs commented May 31, 2022

@Mugurell , do I need to create a PR for Feniix and Focus seperately and mention this issue?

This was referenced May 31, 2022
Closed
Closed
indurs added a commit to indurs/android-components that referenced this issue May 31, 2022
@indurs @Mugurell
For mozilla-mobile#12215 : Expand toolbar when url changes
7f52748 
This fix allows the toolbar to be visible after the user clicks on a link and scrolls

Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
indurs added a commit to indurs/android-components that referenced this issue May 31, 2022
@indurs @Mugurell
For mozilla-mobile#12215 : Expand toolbar when url changes
61a54cd 
This fix allows the toolbar to be visible after the user clicks on a link and scrolls

Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
@Mugurell
Copy link
Contributor Author

@indurs Opened mozilla-mobile/fenix#25455 and mozilla-mobile/focus-android#7140 to update the Fenix and Focus projects after this AC changes.

indurs added a commit to indurs/android-components that referenced this issue May 31, 2022
@indurs @Mugurell
For mozilla-mobile#12215 : Expand toolbar when url changes
baa112c 
This fix allows the toolbar to be visible after the user clicks on a link and scrolls

Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
@indurs
Copy link
Contributor

indurs commented May 31, 2022

Thank You !

Mugurell pushed a commit to indurs/android-components that referenced this issue May 31, 2022
@indurs @Mugurell
For mozilla-mobile#12215: Expand toolbar when the page is loading.
10c137e 
This fix allows the toolbar to be visible after the user clicks on a link and scrolls.
mergify bot pushed a commit that referenced this issue May 31, 2022
@indurs @mergify
For #12215: Expand toolbar when the page is loading.
b850d17 
This fix allows the toolbar to be visible after the user clicks on a link and scrolls.
@Mugurell
Copy link
Contributor Author

PR was merged, thank you @indurs .
Changes are to be tested on Fenix and Focus. Closing this ticket.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@indurs indurs

Labels
<toolbar> Components: browser-toolbar, concept-toolbar
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mugurell @indurs