show toolbar with loading progress when toolbar is hidden and url is tapped

[ryg-git]

Steps to reproduce

1. Search any term on google (ex. search android).
2. scroll up so that the toolbar is hidden.
3. Tap on any search result.
4. check that the toolbar is not revealed after URL tap to show the loading progress.

Expected behavior

1. The toolbar should reveal itself when URL is tapped.
2. Toolbar is revealed on url tap in Firefox Android App (Fenix).
3. This behaviour is especially important in poor network connection, when it gets unclear for user if the URL is tapped properly or not.

Actual behavior

1. when user taps on link to navigate to that URL and the toolbar is hidden bacause of scrolling the toolbar doesn't become visible to show progress.

Device information

• Android device: 12
• Focus version: 100.3.0

[ryg-git]

I would like to take up this issue

[Mugurell]

@ryg-git Thank you for the report!
Just want to confirm that you are reporting the issue for Focus - https://play.google.com/store/apps/details?id=org.mozilla.focus and not for Fenix - the codename for https://play.google.com/store/apps/details?id=org.mozilla.firefox.

I tested now and indeed this issue affects all current Focus releases but Fenix seems to be unaffected.

[Mugurell]

This scenario should probably be accounted for in ToolbarBehaviorController for which I've opened mozilla-mobile/android-components#12215 .

@ryg-git I understand you wanted to work on this?
As per the above the changes are to be implemented in AC (https://github.com/mozilla-mobile/android-components) and Fenix (https://github.com/mozilla-mobile/fenix).
This might help in testing the Android-Components integration in Fenix.

Please let me know if this sounds like something that you can help with or you'd prefer to let us make the changes.

[ryg-git]

Hello @Mugurell,

Thank you for considering my request,

This issue I opened is for focus only, on fenix, toolbar is expended on navigation, sorry if I didn't make it clear in the issue statement.

I checked the fenix code and tried to implement similar behaviour in focus-android, therefore
I added expandToolbarOnNavigation in BrowserToolbarIntegration similar to fenix,
which uses BrowserToolbarBehavior.expand function from android-components.

I think these changes can fix this issue (please checkout gif in the PR I created), please let me know if you want me to change anything.

Thank you!

[Mugurell]

@ryg-git That seems like a nice quick fox for the issue, thank you!
Please mark the PR as ready for review and we'll merge it.

[Mugurell]

Reopen for testing.

[lobontiumira]

Verified as fixed on the latest Focus nightly 102.0a1 from 5/26 with Oppo Reno 6 (Android 12), and Google Pixel (Android 10).