Custom Tab: Handle addDefaultShareMenuItem()

[pocmo]

User story: mozilla-mobile/reference-browser#209

CustomTabsIntent.Builder.addDefaultShareMenuItem().

┆Issue is synchronized with this Jira Task

[jonalmeida]

Looks like we're already handling this in the CustomTabConfig as well:

android-components/components/browser/session/src/main/java/mozilla/components/browser/session/tab/CustomTabConfig.kt

Line 109 in 210751a

val showShareMenuItem = intent.getBooleanExtra(EXTRA_DEFAULT_SHARE_MENU_ITEM, true)

[pocmo]

Yeah, I think CustomTabConfig should be pretty much complete for our purposes. However we are not using the data inside it for anyhting yet. :)

[jonalmeida]

With this one, we have to change the default value in ChromeCustomConfig to false so that we follow this flag correctly.

We also need to add a way to find and remove the share menu in the BrowserMenuBuilder when false.

[pocmo]

I remember we had a UX discussion that lead to the decision to always show the share menu. Maybe that's how we ended up with that default.

We also need to add a way to find and remove the share menu in the BrowserMenuBuilder when false.

I'm currently working on a PR that will as a side effect add unique ids to menu items. That may be helpful here :)

[pocmo]

We also need to add a way to find and remove the share menu in the BrowserMenuBuilder when false.

Another option may be to introduce a visible(Session) like function - similar to the toolbar actions - that gets evaluated when building the menu.

[jonalmeida]

I remember we had a UX discussion that lead to the decision to always show the share menu. Maybe that's how we ended up with that default.

I'll stick with it as the default if there was some historical reason for it - a good use case to see how well our APIs hold up for business logic. ;)

I'm currently working on a PR that will as a side effect add unique ids to menu items. That may be helpful here :)

I was just trying out a solution with a 'tag' as well. I'm glad that I was at least on the right track!

Another option may be to introduce a visible(Session) like function - similar to the toolbar actions - that gets evaluated when building the menu.

We have a visible function already, so I can do this as well with pretty trivial logic which should work, but we would still need to decide on a default for share or use an ID for it since we build the menu only once in the Components.kt. For now, I've made the backing menu list public in the BrowserMenuBuilder since I have to add/remove menu items from the custom tabs config.