Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

lib-crash BreadCrumbs Should Be Dropped Using Priority #4299

Closed
rocketsroger opened this issue Sep 3, 2019 · 0 comments
Closed

lib-crash BreadCrumbs Should Be Dropped Using Priority #4299

rocketsroger opened this issue Sep 3, 2019 · 0 comments
Assignees
@rocketsroger
Labels
<crash> Component: lib-crash 🌟 feature New functionality and improvements
Milestone
14.0.0 🔭

Comments

@rocketsroger
Copy link
Contributor

rocketsroger commented Sep 3, 2019 •
edited by data-sync-user
Loading

Current lib-crash breadcrumb implementation have a maximum of 20 breadcrumbs stored. The breadcrumbs are dropped in the FIFO order. This implementation could be changed to use the breadcrumb priority value so priority + age is used to decide which breadcrumb is first dropped to make room for the new breadcrumb.

┆Issue is synchronized with this Jira Task
@rocketsroger rocketsroger mentioned this issue Sep 3, 2019
Merged
6 tasks
@pocmo pocmo added <crash> Component: lib-crash 🌟 feature New functionality and improvements labels Sep 3, 2019
@rocketsroger rocketsroger self-assigned this Sep 10, 2019
rocketsroger added a commit to rocketsroger/android-components that referenced this issue Sep 16, 2019
@rocketsroger
Closes mozilla-mobile#4299 Add Mechanism to Keep Higher Priority Brea…
0a9db87 
…dcrumbs if Max Number of Breadcrumb is recorded
bors bot pushed a commit that referenced this issue Sep 17, 2019
@MozLando @rocketsroger
Merge #4426
a3637f6 
4426: Closes #4299 Add Mechanism to Keep Higher Priority Breadcrumbs if Max… r=pocmo a=rocketsroger

… Number of Breadcrumb is recorded




Co-authored-by: Roger Yang <royang@mozilla.com>
bors bot pushed a commit that referenced this issue Sep 18, 2019
@MozLando @rocketsroger @NotWoods
Merge #4426 #4440
5dceae5 
4426: Closes #4299 Add Mechanism to Keep Higher Priority Breadcrumbs if Max… r=pocmo a=rocketsroger

… Number of Breadcrumb is recorded




4440: For #4444: Use AndroidX browser 1.2.0-alpha07 r=rocketsroger a=NotWoods

[How to revert](https://docs.google.com/document/d/1IJBC929ntbTuwX7vJOnlFzqkzI-YL2HueelVQeKRPzA/edit)

This version is needed to support Trusted Web Activities.



Co-authored-by: Roger Yang <royang@mozilla.com>
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
@bors bors bot closed this as completed in 11166f3 Sep 18, 2019
@pocmo pocmo added this to the 14.0.0 milestone Sep 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rocketsroger rocketsroger

Labels
<crash> Component: lib-crash 🌟 feature New functionality and improvements
Projects
None yet
Milestone
14.0.0 🔭
Development

No branches or pull requests
2 participants
@pocmo @rocketsroger