This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Integrate GV's new InputResultDetail #9614
Assignees
Labels
E5
Estimation points: 5
<engine-gecko>
Component: browser-engine-gecko
needs:gv
To implement/fix this we need a new API in GeckoView
<toolbar>
Components: browser-toolbar, concept-toolbar
Milestone
Comments
Mugurell
added
<toolbar>
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Mar 5, 2021
Suppress a new deprecation until we'll migrate to the new API in mozilla-mobile#9614
mergify bot
pushed a commit
that referenced
this issue
Mar 8, 2021
Suppress a new deprecation until we'll migrate to the new API in #9614
|
@mcarare can this be closed now? |
4 tasks
|
@gabrielluong I think @Mugurell still has some investigations to do, regarding the use of the additional details the new API provides. |
|
This is not yet started but planning to work on it this week after making a plan for the changes in #9772. |
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Mar 24, 2021
This will serve the following purposes: - wrapper for all the new data from GeckoView's onTouchEventForDetailResult - filters out values not in range (eg: GV's INPUT_RESULT_IGNORED) - controls how the data can be updated and offers clear APIs for querying this data without needing to know about the implementation specifics.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Mar 24, 2021
This will be replaced by the new InputResultDetail.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Mar 24, 2021
Both NestedGeckoView and NestedWebView will now return an InputResultDetail wrapping many new details about how a touch event will be handled. NestedGeckoView's InputResultDetail will be used to more accurately decide when to animate the toolbar or start the pull to refresh feature. NestedWebView's InputResultDetail will only have details about if it will handle the touch or not. With all the other being unknown the dynamic toolbar or pull to refresh features will not work.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Mar 26, 2021
This will serve the following purposes: - wrapper for all the new data from GeckoView's onTouchEventForDetailResult - filters out values not in range (eg: GV's INPUT_RESULT_IGNORED) - controls how the data can be updated and offers clear APIs for querying this data without needing to know about the implementation specifics.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Mar 26, 2021
This will be replaced by the new InputResultDetail.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Mar 26, 2021
Both NestedGeckoView and NestedWebView will now return an InputResultDetail wrapping many new details about how a touch event will be handled. NestedGeckoView's InputResultDetail will be used to more accurately decide when to animate the toolbar or start the pull to refresh feature. NestedWebView's InputResultDetail will only have details about if it will handle the touch or not. With all the other being unknown the dynamic toolbar or pull to refresh features will not work.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Mar 30, 2021
This will serve the following purposes: - wrapper for all the new data from GeckoView's onTouchEventForDetailResult - filters out values not in range (eg: GV's INPUT_RESULT_IGNORED) - controls how the data can be updated and offers clear APIs for querying this data without needing to know about the implementation specifics.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Mar 30, 2021
This will be replaced by the new InputResultDetail.
Mugurell
added a commit
to Mugurell/android-components
that referenced
this issue
Mar 30, 2021
Both NestedGeckoView and NestedWebView will now return an InputResultDetail wrapping many new details about how a touch event will be handled. NestedGeckoView's InputResultDetail will be used to more accurately decide when to animate the toolbar or start the pull to refresh feature. NestedWebView's InputResultDetail will only have details about if it will handle the touch or not. With all the other being unknown the dynamic toolbar or pull to refresh features will not work.
mergify bot
pushed a commit
that referenced
this issue
Mar 30, 2021
This will be replaced by the new InputResultDetail.
mergify bot
pushed a commit
that referenced
this issue
Mar 30, 2021
Both NestedGeckoView and NestedWebView will now return an InputResultDetail wrapping many new details about how a touch event will be handled. NestedGeckoView's InputResultDetail will be used to more accurately decide when to animate the toolbar or start the pull to refresh feature. NestedWebView's InputResultDetail will only have details about if it will handle the touch or not. With all the other being unknown the dynamic toolbar or pull to refresh features will not work.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently the
inputResultfrom GeckoView about how a user touch was handed is cached here and then used for knowing how to animate the toolbars and the pull to refresh throbber.https://bugzilla.mozilla.org/show_bug.cgi?id=1678505 will expose a separate
InputResultDetailthat will expand the low set of valuesInputResultoffered allowing for a better UX of the dynamic toolbars and pull to refresh feature and so fixing a few of the bugs that we have in the process.┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: