Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

For #9614: Integrate new onTouchEventForDetailResult. #9855

Merged
merged 1 commit into from
Mar 10, 2021
Merged

For #9614: Integrate new onTouchEventForDetailResult. #9855

merged 1 commit into from
Mar 10, 2021

Conversation

mcarare
Copy link
Contributor

@mcarare mcarare commented Mar 10, 2021

Fixes #9614

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@mcarare mcarare requested a review from Mugurell March 10, 2021 10:20
Copy link
Contributor

@Mugurell Mugurell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new handledResult seems to offer the same values as before, that we already know to map and use.
The new api comes with other data that can be used later for more accurate toolbar/pull to refresh animations.
Thank you!

@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #9855 (4273346) into master (9483b4a) will decrease coverage by 8.40%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #9855      +/-   ##
============================================
- Coverage     74.06%   65.66%   -8.41%     
+ Complexity     5656      269    -5387     
============================================
  Files           772       94     -678     
  Lines         28761     2257   -26504     
  Branches       4740      362    -4378     
============================================
- Hits          21302     1482   -19820     
+ Misses         4979      617    -4362     
+ Partials       2480      158    -2322     
Impacted Files Coverage Δ Complexity Δ
...nents/browser/state/state/content/DownloadState.kt
.../browser/menu2/adapter/MenuCandidateListAdapter.kt
...s/support/android/test/espresso/ViewInteraction.kt
...re/top/sites/presenter/DefaultTopSitesPresenter.kt
...components/feature/accounts/push/SendTabFeature.kt
...illa/components/feature/search/ext/SearchEngine.kt
...omponents/feature/findinpage/view/FindInPageBar.kt
...va/mozilla/components/service/fxa/manager/State.kt
...ts/feature/customtabs/AbstractCustomTabsService.kt
...feature/syncedtabs/controller/DefaultController.kt
... and 668 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9483b4a...4273346. Read the comment docs.

@mcarare
Copy link
Contributor Author

mcarare commented Mar 10, 2021

Tested on Fenix, The keyboard shows up as expected.
Also played around with some touch events (scrolling, zooming) and I do not see any issues.

@mcarare mcarare added the 🛬 needs landing PRs that are ready to land label Mar 10, 2021
@mergify mergify bot merged commit 7e3b610 into mozilla-mobile:master Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate GV's new InputResultDetail
2 participants