This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Jetpack Compose Integration #10394
Closed
Jetpack Compose Integration #10394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we start reviewing and landing your changes into a branch to avoid reviewing a growing number of file changes and commits? 🧐 |
pocmo
force-pushed
the
compose
branch
7 times, most recently
from
77a865e to
38ac9ff
Compare
|
Some follow-up issues for lint errors: |
… first prototype components. * Issue #10335: Upgrade to Gradle 7. * Update Android Gradle Plugin to 7.0.0 Beta 2. * Issue #10335: Generate BuildConfig with VERSION_CODE and VERSION_NAME fields in library modules (for Glean). * Issue #10335: Add first component using Jetpack Compose: compose-browser-toolbar. * Issue #10335: Introduce Jetpack Compose bindings for lib-state. * Issue #10335: Upstream Jetpack Compose toolbar prototype from Reference Browser. * Issue #10335: Add TargetTab helper for observing specific tabs. * Issue #10335: Add compose-engine component for adding Jetpack Compose bindings to a concept-engine implementation. * Issue #10335: Add new sample app (samples-compose-browser) for prototyping browser UI using Jetpack Compose. * Issue #10335: Update to Beta 3 of the Android Gradle plugin. * Issue #10335: Allow usage of http when substituting maven repositories in CI. * Issue #10335: Rename TabTarget helper to just Target. * Issue #10335: Make BrowserToolbar follow target tab too. * Add awesomebar prototype using Jetpack Compose. * Update to Gradle 7.0.2.
|
Opening new PR for landing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #10212, #10336, #10353, #10359
This is an ongoing branch for integrating the Jetpack Compose setup and some first prototype code. Some changes on this branch are available as separate PRs since they can land earlier. The goal is to keep this branch going until we feel comfortable continuing on
master(mostly because it currently requires beta tooling and dependencies).