This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Work in progress: Complete browser-state migration #10212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocmo
added
work in progress
Codecov Report
@@ Coverage Diff @@
## master #10212 +/- ##
============================================
+ Coverage 74.11% 75.48% +1.36%
+ Complexity 6318 3947 -2371
============================================
Files 842 524 -318
Lines 32022 19914 -12108
Branches 5335 3307 -2028
============================================
- Hits 23734 15032 -8702
+ Misses 5557 3144 -2413
+ Partials 2731 1738 -993
Continue to review full report at Codecov.
|
* Issue #10197: Move EngineObserver and EngineMiddleware to browser-state and refactor SessionManager dependency away. * Issue #3532: Migrate TabsUseCases to use BrowserStore exclusively. * Issue #10209: Migrate SessionUseCases to use BrowserStore exclusively. * Issue #3532, #10209: Migrate components to use new UseCase APIs. * Issue #10209: Migrate UndoMiddleware to use BrowserStore. * Issue #3532: Migrate CustomTabsUseCases to use BrowserStore. * Issue #10211: Migrate sample-browser to not depend on browser-session. * Issue #10209: Remove browser-session dependency. * Issue #3532: feature-tabs: Remove browser-session dependency. * Issue #10209: Fix UndoMiddlewareTest * Issue #10209: Refactor SessionUseCasesTest to not use SessionManager. * Issue #10209: Fix SessionFeatureTest. * Refactor support-migration tests to not use SessionManager. * Fix tests in feature-contextmenu. * Refactor feature-recentlyclosed tests to not use SessionManager * Refactor browser-session-storage tests to not use SessionManager * Refactor feature-intent tests to not use SessionManager * Refactor feature-tabs tests to not use SessionManager pt. 1 * Refactor feature-customtabs tests to not depend on browser-session. * Make sure initial load url flags are correct * Refactor feature-tabs tests to not use SessionManager pt. 2 * Refactor browser-state tests to not depend on browser-session. * SearchUseCasesTest: Use addTab use case instead of addPrivateTab. * Samples Browser: Remove unused drawable. * Fix feature-pwa tests * Remove browser-session. * Make sure engine session is linked for window requests * Make sure engine session is linked when provided with tab * Make sure engine session is linked when provided with tab pt. 2 * Prevent engine session from being created multiple times * Prevent engine session from being created multiple times pt. 2 * Prevent engine session from being created multiple times pt. 3 * Part 4: REFACTOR ALL THE THINGS * Update tests. * Add additional test for multiple CreateEngineSessionAction dispatching. * Refactor, some docs and tests * Fix CustomTabs tests...
pocmo
removed
do not land
pocmo
requested review from
Amejia481,
csadilek,
grigoryk,
jonalmeida and
a team
as code owners
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress PR / branch completing the browser-state migration. It's not near ready yet, but the plan is to update over the next days/weeks and finally complete it and create the complementing Fenix / Focus / RB branches.