Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Context Menu feature... #1459

Merged
merged 2 commits into from
Nov 26, 2018
Merged

Context Menu feature... #1459

merged 2 commits into from
Nov 26, 2018

Conversation

pocmo
Copy link
Contributor

@pocmo pocmo commented Nov 23, 2018

Closes #1386

@pocmo pocmo added the 🕵️‍♀️ needs review PRs that need to be reviewed label Nov 23, 2018
@pocmo pocmo requested a review from a team as a code owner November 23, 2018 17:15
Copy link
Contributor

@Amejia481 Amejia481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@codecov
Copy link

codecov bot commented Nov 23, 2018

Codecov Report

Merging #1459 into master will increase coverage by 0.42%.
The diff coverage is 88.44%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1459      +/-   ##
============================================
+ Coverage     82.88%   83.31%   +0.42%     
- Complexity     1766     1796      +30     
============================================
  Files           219      228       +9     
  Lines          6655     7005     +350     
  Branches       1093     1120      +27     
============================================
+ Hits           5516     5836     +320     
- Misses          638      649      +11     
- Partials        501      520      +19
Impacted Files Coverage Δ Complexity Δ
...la/components/feature/tabs/tabstray/TabsFeature.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...ts/feature/tabs/toolbar/TabCounterToolbarButton.kt 90.47% <100%> (+1%) 2 <0> (ø) ⬇️
...va/mozilla/components/feature/tabs/TabsUseCases.kt 100% <100%> (ø) 1 <0> (ø) ⬇️
...mponents/feature/contextmenu/ContextMenuFeature.kt 86.11% <86.11%> (ø) 13 <13> (?)
...ponents/feature/contextmenu/ContextMenuFragment.kt 88.63% <88.63%> (ø) 7 <7> (?)
...onents/feature/contextmenu/ContextMenuCandidate.kt 89.06% <89.06%> (ø) 6 <6> (?)
...java/mozilla/components/concept/engine/Settings.kt 100% <0%> (ø) 1% <0%> (?)
...nents/concept/engine/request/RequestInterceptor.kt 100% <0%> (ø) 0% <0%> (?)
...mozilla/components/concept/engine/EngineSession.kt 86.66% <0%> (ø) 2% <0%> (?)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2af68eb...a6a394b. Read the comment docs.

Copy link
Contributor

@csadilek csadilek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! :)

@pocmo pocmo changed the title Contextmenu Context Menu feature Nov 23, 2018
@pocmo pocmo changed the title Context Menu feature Context Menu feature. Nov 23, 2018
@pocmo pocmo changed the title Context Menu feature. Context Menu feature.. Nov 23, 2018
@pocmo pocmo changed the title Context Menu feature.. Context Menu feature... Nov 26, 2018
@pocmo pocmo merged commit ada6f4f into mozilla-mobile:master Nov 26, 2018
@pocmo pocmo deleted the contextmenu branch November 26, 2018 11:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕵️‍♀️ needs review PRs that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants