This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 472
Add new TabsUseCases for closing all sessions #1457
Labels
🌟 feature
New functionality and improvements
good first issue
Good for newcomers
help wanted
Extra attention is needed
💡idea
Ideas for a new component, feature, change ..
<tabs>
Components: browser-tabstray, feature-tabs
Milestone
Comments
jonalmeida
added
help wanted
Extra attention is needed
good first issue
Good for newcomers
🌟 feature
New functionality and improvements
<tabs>
Components: browser-tabstray, feature-tabs
💡idea
Ideas for a new component, feature, change ..
labels
Nov 23, 2018
FYI: In the context menu PR that I'm going to open now I renamed some of the use case classes inside |
@jonalmeida @pocmo can i take it up? |
@chikka Definitely! Although you should wait for #1459 to get merged. If you're keen to work on this ASAP, then you can work off that branch. Have a look at |
@jonalmeida Thanks!. I have looked into it and I think we need to create two classes for it
Please let me know your thoughts on it |
@chikka looks great! Feel free to create a PR and we talk review it there as well. Small nit: fun invoke(privateOnly: Boolean = false) { } I'd change the attribute name from |
chikka
added a commit
to chikka/android-components
that referenced
this issue
Nov 27, 2018
… tabs and related test cases
chikka
added a commit
to chikka/android-components
that referenced
this issue
Nov 27, 2018
chikka
added a commit
to chikka/android-components
that referenced
this issue
Dec 13, 2018
chikka
added a commit
to chikka/android-components
that referenced
this issue
Dec 13, 2018
pocmo
pushed a commit
that referenced
this issue
Dec 17, 2018
pocmo
pushed a commit
that referenced
this issue
Dec 17, 2018
pocmo
pushed a commit
that referenced
this issue
Dec 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
🌟 feature
New functionality and improvements
good first issue
Good for newcomers
help wanted
Extra attention is needed
💡idea
Ideas for a new component, feature, change ..
<tabs>
Components: browser-tabstray, feature-tabs
We need a use case that lets you close:
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: