Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

close #1270: Updated BrowserToolbar.ToggleButton and BrowserToolbar.Button . #1460

Merged
merged 1 commit into from
Nov 23, 2018

Conversation

chikka
Copy link
Contributor

@chikka chikka commented Nov 23, 2018

Removed redundant setPadding and overriding methods

…utton

removed redundant setPadding and  overriding methods
@chikka chikka requested a review from a team as a code owner November 23, 2018 17:32
@pocmo pocmo requested a review from jonalmeida November 23, 2018 17:33
@pocmo pocmo added the 🕵️‍♀️ needs review PRs that need to be reviewed label Nov 23, 2018
@jonalmeida jonalmeida changed the title close #1270: Updated BrowserToolbar.ToggleButton and BrowserToolbar.Button close #1270: Updated BrowserToolbar.ToggleButton and BrowserToolbar.Button . Nov 23, 2018
@codecov
Copy link

codecov bot commented Nov 23, 2018

Codecov Report

Merging #1460 into master will increase coverage by 0.23%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1460      +/-   ##
============================================
+ Coverage     82.88%   83.12%   +0.23%     
- Complexity     1766     1770       +4     
============================================
  Files           219      225       +6     
  Lines          6655     6785     +130     
  Branches       1093     1098       +5     
============================================
+ Hits           5516     5640     +124     
- Misses          638      640       +2     
- Partials        501      505       +4
Impacted Files Coverage Δ Complexity Δ
...zilla/components/browser/toolbar/BrowserToolbar.kt 100% <100%> (ø) 55 <0> (ø) ⬇️
...java/mozilla/components/concept/engine/Settings.kt 100% <0%> (ø) 1% <0%> (?)
...nents/concept/engine/request/RequestInterceptor.kt 100% <0%> (ø) 0% <0%> (?)
...mozilla/components/concept/engine/EngineSession.kt 86.66% <0%> (ø) 2% <0%> (?)
...va/mozilla/components/concept/engine/EngineView.kt 86.66% <0%> (ø) 0% <0%> (?)
...ava/mozilla/components/concept/engine/HitResult.kt 100% <0%> (ø) 1% <0%> (?)
...nts/concept/engine/permission/PermissionRequest.kt 100% <0%> (ø) 0% <0%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2af68eb...1bd726b. Read the comment docs.

Copy link
Contributor

@jonalmeida jonalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Thanks @chikka! If you're interested in trying out another issue I filed #1457 recently as well that's a little bit more challenging (only a little!) than this one. :)

Otherwise, check out our 'help wanted' label if you're interested in something.

@jonalmeida jonalmeida merged commit 13d4901 into mozilla-mobile:master Nov 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕵️‍♀️ needs review PRs that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants