-
Notifications
You must be signed in to change notification settings - Fork 473
For issue #3264 Add api for interacting with the tracking protection exceptions #4554
Conversation
Related #4441 |
@csadilek we can land this and open a bugzilla bug to follow up the issue that we discussed before. |
Codecov Report
@@ Coverage Diff @@
## master #4554 +/- ##
============================================
+ Coverage 81.32% 83.27% +1.95%
+ Complexity 3755 2959 -796
============================================
Files 515 396 -119
Lines 16744 12665 -4079
Branches 2445 1838 -607
============================================
- Hits 13617 10547 -3070
+ Misses 2189 1379 -810
+ Partials 938 739 -199
Continue to review full report at Codecov.
|
bb6b9c6
to
6b310c4
Compare
I really don't know how to get this inline code covered. As It has tests but jacoco is ignoring it :( This is a known issue jacoco/jacoco#654, I don't really want to trade the benefits of inline by code coverage. I'm not quite sure what should I do here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! One comment / change request for the concept engine bits.
components/concept/engine/src/main/java/mozilla/components/concept/engine/Engine.kt
Outdated
Show resolved
Hide resolved
...ava/mozilla/components/concept/engine/content/blocking/TrackingProtectionExceptionStorage.kt
Outdated
Show resolved
Hide resolved
...ava/mozilla/components/concept/engine/content/blocking/TrackingProtectionExceptionStorage.kt
Outdated
Show resolved
Hide resolved
...ature/session/src/main/java/mozilla/components/feature/session/TrackingProtectionUseCases.kt
Outdated
Show resolved
Hide resolved
…ng protection exceptions.
6b310c4
to
976349b
Compare
bors r=csadilek |
👎 Rejected by too few approved reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
Build succeeded |
Pull Request checklist
After merge