Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

For issue #3264 Add api for interacting with the tracking protection exceptions #4554

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

Amejia481
Copy link
Contributor


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@Amejia481 Amejia481 added the 🕵️‍♀️ needs review PRs that need to be reviewed label Sep 26, 2019
@Amejia481
Copy link
Contributor Author

Related #4441

@Amejia481
Copy link
Contributor Author

Amejia481 commented Sep 26, 2019

@csadilek we can land this and open a bugzilla bug to follow up the issue that we discussed before.

@Amejia481 Amejia481 changed the title For issue #3264 Add api for interacting with the tracking protection exceptions. For issue #3264 Add api for interacting with the tracking protection exceptions Sep 26, 2019
@codecov
Copy link

codecov bot commented Sep 26, 2019

Codecov Report

Merging #4554 into master will increase coverage by 1.95%.
The diff coverage is 59.18%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4554      +/-   ##
============================================
+ Coverage     81.32%   83.27%   +1.95%     
+ Complexity     3755     2959     -796     
============================================
  Files           515      396     -119     
  Lines         16744    12665    -4079     
  Branches       2445     1838     -607     
============================================
- Hits          13617    10547    -3070     
+ Misses         2189     1379     -810     
+ Partials        938      739     -199
Impacted Files Coverage Δ Complexity Δ
...zilla/components/browser/session/ext/AtomicFile.kt 87.5% <ø> (+4.16%) 0 <0> (ø) ⬇️
.../mozilla/components/support/ktx/util/AtomicFile.kt 0% <0%> (ø) 0 <0> (?)
...n/java/mozilla/components/concept/engine/Engine.kt 41.93% <100%> (+1.93%) 0 <0> (ø) ⬇️
...ents/feature/session/TrackingProtectionUseCases.kt 100% <100%> (ø) 3 <0> (ø) ⬇️
...lla/components/support/base/observer/Consumable.kt
...in/java/mozilla/components/support/base/log/Log.kt
...ponents/feature/sitepermissions/SitePermissions.kt
...illa/components/service/experiments/Experiments.kt
...components/browser/icons/decoder/ICOIconDecoder.kt
...mozilla/components/service/fxa/sync/SyncManager.kt
... and 164 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44eac4b...976349b. Read the comment docs.

@Amejia481 Amejia481 requested a review from csadilek September 26, 2019 22:31
@Amejia481 Amejia481 force-pushed the add_exception_list_api branch from bb6b9c6 to 6b310c4 Compare September 26, 2019 23:46
@Amejia481 Amejia481 changed the title For issue #3264 Add api for interacting with the tracking protection exceptions For issue #3264 Add api for interacting with the tracking protection exceptions. Sep 27, 2019
@Amejia481
Copy link
Contributor Author

Amejia481 commented Sep 27, 2019

I really don't know how to get this inline code covered. As It has tests but jacoco is ignoring it :(

This is a known issue jacoco/jacoco#654, I don't really want to trade the benefits of inline by code coverage. I'm not quite sure what should I do here.
image

@Amejia481 Amejia481 changed the title For issue #3264 Add api for interacting with the tracking protection exceptions. For issue #3264 Add api for interacting with the tracking protection exceptions Sep 27, 2019
Copy link
Contributor

@csadilek csadilek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One comment / change request for the concept engine bits.

@Amejia481
Copy link
Contributor Author

bors r=csadilek

@bors
Copy link

bors bot commented Sep 27, 2019

👎 Rejected by too few approved reviews

Copy link
Contributor

@csadilek csadilek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Sep 27, 2019
4554: For issue #3264 Add api for interacting with the tracking protection exceptions r=csadilek a=Amejia481



Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
@bors
Copy link

bors bot commented Sep 27, 2019

Build succeeded

@bors bors bot merged commit 976349b into mozilla-mobile:master Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕵️‍♀️ needs review PRs that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants