Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Integrate new TP Exceptions Management API #5646

Closed
3 tasks
ekager opened this issue Sep 27, 2019 · 3 comments
Closed
3 tasks

Integrate new TP Exceptions Management API #5646

ekager opened this issue Sep 27, 2019 · 3 comments
Assignees
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified eng:ready Ready for engineering Feature:TrackingProtection needs:ac Needs Android Component Work 🙅 waiting Issues that are blocked or has dependencies that are not ready

Comments

@ekager
Copy link
Contributor

ekager commented Sep 27, 2019

What

Add the new Exceptions Management UI for controlling ETP settings on sites

Should be merged in AC soon and then Fenix needs to integrate the new way of handling TP exceptions.
mozilla-mobile/android-components#4554

QA

  • Verify that the 4 tracking states at the top of the ETP SUMO article (blue, black, crossed out, no shield) are working as described
  • Sites can be added to the exceptions list
  • Sites can be removed from the exceptions list when on the site itself, through the shield icon menu toggle

┆Issue is synchronized with this Jira Task

@ekager ekager added P1 Current sprint Feature:TrackingProtection E5 Estimation Point: about 5 days labels Sep 27, 2019
@ekager ekager self-assigned this Sep 27, 2019
@ekager ekager added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Sep 27, 2019
@vesta0 vesta0 mentioned this issue Sep 27, 2019
5 tasks
@vesta0 vesta0 added needs:ac Needs Android Component Work must and removed P1 Current sprint labels Sep 27, 2019
@liuche liuche added needs:ac Needs Android Component Work eng:ready Ready for engineering and removed needs:ac Needs Android Component Work 🙅 waiting Issues that are blocked or has dependencies that are not ready labels Oct 5, 2019
@sblatz
Copy link
Contributor

sblatz commented Oct 11, 2019

E1 of this work is left, we're pulling it out to run the experiment before removing the feature flag :)

@vesta0 vesta0 added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Oct 11, 2019
@liuche
Copy link
Contributor

liuche commented Oct 14, 2019

This will be ready to go out once the experiment is finished, which I think is 11/5? (end of observation - double check w/ @mythmon )

@liuche liuche mentioned this issue Oct 31, 2019
10 tasks
@ekager ekager added the eng:qa:needed QA Needed label Nov 5, 2019
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Nov 7, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Nov 7, 2019

Hi, verified as fixed on the latest Nightly Build #13110606 from 7/11 using the following devices:
• Google Pixel 3a XL (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

►Video
20191107_123106

@AndiAJ AndiAJ closed this as completed Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified eng:ready Ready for engineering Feature:TrackingProtection needs:ac Needs Android Component Work 🙅 waiting Issues that are blocked or has dependencies that are not ready
Projects
None yet
Development

No branches or pull requests

5 participants