Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Turn on ETP for all users #6354

Closed
4 of 10 tasks
liuche opened this issue Oct 31, 2019 · 6 comments
Closed
4 of 10 tasks

Turn on ETP for all users #6354

liuche opened this issue Oct 31, 2019 · 6 comments
Assignees
Milestone

Comments

@liuche
Copy link
Contributor

liuche commented Oct 31, 2019

User Story

We want to turn on Enhanced Tracking Protection for all users, after the experiment #5651 runs.

Dependencies

Acceptance Criteria

QA

  • Verify that on release build 3.0 the setting strict is the default

Meta issue: #1749

┆Issue is synchronized with this Jira Task

@liuche
Copy link
Contributor Author

liuche commented Oct 31, 2019

@vesta0 Will we have the decision from the experiment (default is strict or standard) by the time 3.0 is ready to ship? Looking at the Experimenter guide, it looks like if the experiment runs for 21 days (7 days enrollment, 14 days observation), and we start Nov 1, it won't be ready until Nov 22.

If we won't get the results in time, some possible cases:

  • we could delay the 3.0 release (this would be a good time to do the beta!)
  • we could ship a 2.4
  • we could ship 3.0 on time, but with whichever setting we choose (which would....not rely on the experimental data) ship with strict mode and the experimental data would be used later

@vesta0
Copy link
Collaborator

vesta0 commented Oct 31, 2019

@ekager thanks for investigating, I recommend going with Option B :)

@liuche
Copy link
Contributor Author

liuche commented Nov 7, 2019

Ugh, sorry I think I got confused - actually @ekager if we want this in 3.0, we should put it into the release, because it's going to be in beta anyway (and not actually released), so it can get QA-ed during the beta period 🤦‍♀

@severinrudie severinrudie added the eng:qa:needed QA Needed label Nov 7, 2019
@severinrudie severinrudie mentioned this issue Nov 7, 2019
30 tasks
@ekager
Copy link
Contributor

ekager commented Nov 7, 2019

QA - please verify for both 3.0 and Nightly that

  1. The ETP dialog with shield in toolbar is visible and displays correctly
  2. The Quick Settings bottom dialog (Lock Icon) displays correctly and does not include TP UI
  3. The granular options for Strict/Standard display in TP Settings

@lobontiumira
Copy link

lobontiumira commented Nov 8, 2019

We've verified on the 3.0.0-beta.1, and on 11/08 Nightly build, the

  • ETP shield dialog with is visible and is displayed correctly,
  • the lock icon is displayed correctly and doesn't include TP UI,
  • the granular options for Strict or Standard are displayed in Settings,
  • the setting "Strict" is the default one.

Verified with Samsung Galaxy Note 8 (Android 9), Google Pixel (Android Q).

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Nov 8, 2019
@ekager ekager closed this as completed Nov 8, 2019
@liuche
Copy link
Contributor Author

liuche commented Nov 13, 2019

@ekager update the checkboxes here, or reopen?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants