For #6070 Adds telemetry for enabling search suggestions in private

mozilla-mobile · Nov 22, 2019 · e402d09 · e402d09
1 parent 9869408
commit e402d09
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/app/metrics.yaml b/app/metrics.yaml
@@ -114,20 +114,22 @@ events:
         description: "The preference key for the boolean (true/false) preference the user toggled. We currently track:
           show_search_suggestions, remote_debugging, telemetry, tracking_protection, search_bookmarks,
           search_browsing_history, show_clipboard_suggestions, show_search_shortcuts, open_links_in_a_private_tab,
-          and pref_key_sync_logins"
+          pref_key_sync_logins and pref_key_show_search_suggestions_in_private"
       enabled:
         description: "Whether or not the preference is *now* enabled"
     bugs:
     - https://github.com/mozilla-mobile/fenix/issue/975
     - https://github.com/mozilla-mobile/fenix/issue/5094
     - https://github.com/mozilla-mobile/fenix/issues/5737
     - https://github.com/mozilla-mobile/fenix/issues/5586
+    - https://github.com/mozilla-mobile/fenix/issues/6070
     data_reviews:
     - https://github.com/mozilla-mobile/fenix/pull/1896
     - https://github.com/mozilla-mobile/fenix/pull/5704
     - https://github.com/mozilla-mobile/fenix/pull/5886
     - https://github.com/mozilla-mobile/fenix/pull/5975
     - https://github.com/mozilla-mobile/fenix/pull/6352
+    - https://github.com/mozilla-mobile/fenix/pull/6746
     notification_emails:
     - fenix-core@mozilla.com
     expires: "2020-03-01"

diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt
@@ -445,6 +445,7 @@ private val Event.wrapper: EventWrapper<*>?
         is Event.ViewLoginPassword -> EventWrapper<NoExtraKeys>(
             { Logins.viewPasswordLogin.record(it) }
         )
+        Event.PrivateBrowsingShowSearchSuggestions -> TODO()
         // Don't record other events in Glean:
         is Event.AddBookmark -> null
         is Event.OpenedBookmark -> null

diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/Metrics.kt
@@ -136,6 +136,7 @@ sealed class Event {
     object OpenOneLogin : Event()
     object CopyLogin : Event()
     object ViewLoginPassword : Event()
+    object PrivateBrowsingShowSearchSuggestions : Event()
 
     // Interaction events with extras
 
@@ -150,7 +151,8 @@ sealed class Event {
             context.getString(R.string.pref_key_show_clipboard_suggestions),
             context.getString(R.string.pref_key_show_search_shortcuts),
             context.getString(R.string.pref_key_open_links_in_a_private_tab),
-            context.getString(R.string.pref_key_sync_logins)
+            context.getString(R.string.pref_key_sync_logins),
+            context.getString(R.string.pref_key_show_search_suggestions_in_private)
         )
 
         override val extras: Map<Events.preferenceToggledKeys, String>?

diff --git a/app/src/main/java/org/mozilla/fenix/search/SearchFragment.kt b/app/src/main/java/org/mozilla/fenix/search/SearchFragment.kt
@@ -204,6 +204,7 @@ class SearchFragment : Fragment(), BackHandler {
                 inflated.visibility = View.GONE
                 context?.settings()?.shouldShowSearchSuggestionsInPrivate = true
                 context?.settings()?.showSearchSuggestionsInPrivateOnboardingFinished = true
+                context?.components?.analytics?.metrics?.track(Event.PrivateBrowsingShowSearchSuggestions)
             }
 
             inflated.dismiss.setOnClickListener {