Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Swipe to delete bookmarks #12551

Closed
person808 opened this issue Jul 14, 2020 · 4 comments
Closed

Swipe to delete bookmarks #12551

person808 opened this issue Jul 14, 2020 · 4 comments
Assignees
Labels

Comments

@person808
Copy link
Contributor

person808 commented Jul 14, 2020

Broken out from #176

What is the user problem or growth opportunity you want to see solved?

Users should be able to swipe to delete bookmarks.

How do you know that this problem exists today? Why is this important?

This is not possible currently. Deletion is done by tapping the three dot menu and selecting delete.

Who will benefit from it?

Everyone who deletes items from bookmarks.

┆Issue is synchronized with this Jira Task

@person808 person808 self-assigned this Jul 14, 2020
@lime124 lime124 mentioned this issue Jul 14, 2020
18 tasks
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 14, 2020
@eliserichards eliserichards added the feature request 🌟 New functionality and improvements label Jul 14, 2020
@person808
Copy link
Contributor Author

Going to break swipe to delete history out into a separate issue because there are some problems with implementing it that need more thought.

@person808 person808 changed the title Swipe to delete bookmarks/history Swipe to delete bookmarks Jul 15, 2020
person808 added a commit to person808/fenix that referenced this issue Jul 16, 2020
person808 added a commit to person808/fenix that referenced this issue Jul 17, 2020
person808 added a commit to person808/fenix that referenced this issue Jul 20, 2020
person808 added a commit to person808/fenix that referenced this issue Jul 20, 2020
@person808 person808 added the eng:qa:needed QA Needed label Jul 21, 2020
@ghost
Copy link

ghost commented Jul 22, 2020

@person808

There's a bug with this behaviour. See the GIFs. You may need to swipe a bit diagonally to reproduce it. Even if I try to swipe exactly horizontally in a straight line it reproduces most of the time and of course I can do the swipe to delete gestures action if I try harder but it's not intuitive and the swipe action seems to be triggering the 3-dot menu which I think it should not.

See the GIFs:
20200722_093112

20200722_093241

Thank you. :)

@person808
Copy link
Contributor Author

Hm that definitely doesn't seem right. Could you open a new issue with what you posted and tag me? I'll add it to my backlog. Thanks!

@sflorean
Copy link
Contributor

Verified as fixed on Nightly 7/24 with Samsung Galaxy Note 10(Android 10) and Huawei MediaPad M2(Android 5.1.1).

@ShatteredPixel I was able to reproduce your issue also, I will leave a comment on the bug.

@sflorean sflorean added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jul 24, 2020
@data-sync-user data-sync-user changed the title Swipe to delete bookmarks FNX3-13531 ⁃ Swipe to delete bookmarks Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-13531 ⁃ Swipe to delete bookmarks FNX-13634 ⁃ Swipe to delete bookmarks Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-13634 ⁃ Swipe to delete bookmarks FNX2-15323 ⁃ Swipe to delete bookmarks Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-15323 ⁃ Swipe to delete bookmarks Swipe to delete bookmarks May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants