Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Glitches with the swipe to delete gesture action for bookmarks #12831

Closed
ghost opened this issue Jul 22, 2020 · 2 comments
Closed

[Bug] Glitches with the swipe to delete gesture action for bookmarks #12831

ghost opened this issue Jul 22, 2020 · 2 comments
Assignees
@person808
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Bookmarks Feature:Gesture

Comments

@ghost
Copy link

ghost commented Jul 22, 2020 •
edited by data-sync-user
Loading

This was first reported here: #12551 (comment)

There's a bug with this behaviour (Swipe to delete bookmarks). See the GIFs. I cannot delete bookmarks easily due the glitches in this gesture behaviour. You may need to swipe a bit diagonally to reproduce it. Even if I try to swipe exactly horizontally in a straight line it reproduces most of the time and of course I can do the swipe to delete gestures action if I try harder but it's not intuitive and the swipe action seems to be triggering the 3-dot menu button of bookmarks, which I think it should not.

Edit: Observe that this gestures action seems to be also triggering the "pull to refresh" action in bookmarks screen.

Device: Motorola One Power, Android 10.
Fenix: Nightly 200721 06:05

See the GIFs:
20200722UNITO-UNDERSCORE!093112!

20200722UNITO-UNDERSCORE!093241!

Thank you. 😀

┆Issue is synchronized with this Jira Task
@ghost ghost added the 🐞 bug Crashes, Something isn't working, .. label Jul 22, 2020
@ghost
Copy link
Author

ghost commented Jul 22, 2020

CC @person808

@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 22, 2020
@person808 person808 self-assigned this Jul 22, 2020
person808 added a commit to person808/fenix that referenced this issue Jul 29, 2020
@person808
For mozilla-mobile#12831 - Disable SwipeRefreshLayout while swiping a…
7ad12b3 
… bookmark.
person808 added a commit to person808/fenix that referenced this issue Jul 29, 2020
@person808
For mozilla-mobile#12831 - Disable SwipeRefreshLayout while swiping a…
be64727 
… bookmark.
person808 added a commit to person808/fenix that referenced this issue Jul 30, 2020
@person808
For mozilla-mobile#12831 - Disable SwipeRefreshLayout while swiping a…
7db0229 
… bookmark.
person808 added a commit to person808/fenix that referenced this issue Jul 31, 2020
@person808
For mozilla-mobile#12831 - Disable SwipeRefreshLayout while swiping a…
b61d327 
… bookmark.
person808 added a commit to person808/fenix that referenced this issue Aug 4, 2020
@person808
For mozilla-mobile#12831 - Disable SwipeRefreshLayout while swiping a…
a577b9f 
… bookmark.
person808 added a commit to person808/fenix that referenced this issue Aug 4, 2020
@person808
For mozilla-mobile#12831 - Disable SwipeRefreshLayout while swiping a…
c0d8953 
… bookmark.
person808 added a commit that referenced this issue Aug 5, 2020
@person808
For #12831 - Disable SwipeRefreshLayout while swiping a bookmark.
30c7b5e
@person808 person808 added the eng:qa:needed QA Needed label Aug 5, 2020
@data-sync-user data-sync-user changed the title [Bug] Glitches with the swipe to delete gesture action for bookmarks FNX3-21912 ⁃ [Bug] Glitches with the swipe to delete gesture action for bookmarks Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-21912 ⁃ [Bug] Glitches with the swipe to delete gesture action for bookmarks FNX-13960 ⁃ [Bug] Glitches with the swipe to delete gesture action for bookmarks Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-13960 ⁃ [Bug] Glitches with the swipe to delete gesture action for bookmarks FNX2-15489 ⁃ [Bug] Glitches with the swipe to delete gesture action for bookmarks Aug 11, 2020
@abodea
Copy link
Member

abodea commented Aug 21, 2020

Verified as fixed on the latest Nightly 8/21 with Google Pixel 4 XL (11).

@abodea abodea added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Aug 21, 2020
@Mugurell Mugurell mentioned this issue Nov 20, 2020
Merged
3 tasks
kleinph added a commit to kleinph/fenix that referenced this issue Nov 21, 2020
@kleinph
For mozilla-mobile#12831: Remove obsolete swipe refresh state from Bo…
79e2091 
…okmarkFragmentState

Also adapt tests and remove obsolete ones.
@data-sync-user data-sync-user changed the title FNX2-15489 ⁃ [Bug] Glitches with the swipe to delete gesture action for bookmarks [Bug] Glitches with the swipe to delete gesture action for bookmarks May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@person808 person808

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Bookmarks Feature:Gesture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@person808 @ekager @abodea @data-sync-user