Skip to content
This repository was archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]No fill from clipboard for a link copied from imgur.com #1695

Closed
sv-ohorvath opened this issue Apr 17, 2019 · 7 comments
Closed

[Bug]No fill from clipboard for a link copied from imgur.com #1695

sv-ohorvath opened this issue Apr 17, 2019 · 7 comments
Labels
b:web-content Issues with websites. Check to see if the issue is GV or WebCompat too 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified needs:investigation P2 Upcoming release

Comments

@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Apr 17, 2019

Steps to reproduce

  1. Go to imgur.com.
  2. Tap the title of a post. Tap on "copy link"
  3. Open a new tab, tap the address bar.
    1. Expected behavior
      Fill link from clipboard option is shown.
    2. Actual behavior
      No link from clipboard shown.
      If you paste the link directly, it will work.
      Other links copied from other sources (other apps, 9gag website) work.
    3. Device information
  • Android device: Pxiel, Nexus 5
  • Fenix version: 4/17.

┆Issue is synchronized with this Jira Task

@sv-ohorvath sv-ohorvath added the 🐞 bug Crashes, Something isn't working, .. label Apr 17, 2019
@kbrosnan kbrosnan added the b:web-content Issues with websites. Check to see if the issue is GV or WebCompat too label Apr 27, 2019
@vesta0
Copy link
Collaborator

vesta0 commented Apr 30, 2019

@sv-ohorvath this looks fixed. Please verify.

@sv-ohorvath
Copy link
Contributor Author

I can still reproduce it on the 4/29 build:
20190430_121027

@vesta0
Copy link
Collaborator

vesta0 commented Apr 30, 2019

Strange that it works for me. We should investigate.

@vesta0 vesta0 added the P2 Upcoming release label Apr 30, 2019
@vesta0 vesta0 added this to the Bugs milestone Apr 30, 2019
@ekager
Copy link
Contributor

ekager commented Jul 12, 2019

@sv-ohorvath can you still reproduce? I can't on master with Pixel

@ekager ekager added the eng:qa:needed QA Needed label Jul 12, 2019
@sv-ohorvath
Copy link
Contributor Author

We can still reproduce this on Pixel 3A, Pixel 3XL, Galaxy S8 (Android 9), Nexus 5 (Android 6.0.1) on Nightly 7/15.
It also happens copying the build date from taskcluster: tap the Created date to copy it (https://tools.taskcluster.net/index/project.mobile.fenix.v2.nightly/latest)

@sv-ohorvath sv-ohorvath added in progress and removed eng:qa:needed QA Needed labels Jul 15, 2019
@boek boek removed this from the Bugs and Polish milestone Jul 17, 2019
@vesta0 vesta0 removed this from the Bugs and Polish milestone Jul 24, 2019
@ekager
Copy link
Contributor

ekager commented Nov 14, 2019

In ClipboardHandler.kt after copying this link, text is returning null because the mime type is text/html not the expected text/plain - so we aren't even attempting to get the URL. I think if we open up the mime type this should work.

vespertineSiren added a commit to vespertineSiren/fenix that referenced this issue Nov 15, 2019
vespertineSiren added a commit to vespertineSiren/fenix that referenced this issue Nov 15, 2019
vespertineSiren added a commit to vespertineSiren/fenix that referenced this issue Nov 15, 2019
ekager pushed a commit that referenced this issue Nov 15, 2019
* For #1695 - Detect HTML mime type for clipboard URL
@ekager ekager added the eng:qa:needed QA Needed label Nov 15, 2019
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Nov 18, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Nov 18, 2019

Hi, verified as fixed on the latest Nightly Build #13220606 from 11/18 using the following devices:
• Google Pixel 3a XL (Android 9)
• Huawei Mate 20 Lite (Android 8.1.0)
• Samsung Galaxy S7 (Android 7)
• OnePlus A3 (Android 6.0.1)
• LG Nexus 4 (Android 5.1.1)

► Video
20191118_103223

@AndiAJ AndiAJ closed this as completed Nov 18, 2019
vespertineSiren added a commit to vespertineSiren/fenix that referenced this issue Nov 18, 2019
vespertineSiren added a commit to vespertineSiren/fenix that referenced this issue Nov 18, 2019
vespertineSiren added a commit to vespertineSiren/fenix that referenced this issue Nov 18, 2019
vespertineSiren added a commit to vespertineSiren/fenix that referenced this issue Nov 18, 2019
vespertineSiren added a commit to vespertineSiren/fenix that referenced this issue Nov 18, 2019
vespertineSiren added a commit to vespertineSiren/fenix that referenced this issue Nov 19, 2019
vespertineSiren added a commit to vespertineSiren/fenix that referenced this issue Nov 19, 2019
vespertineSiren added a commit to vespertineSiren/fenix that referenced this issue Nov 19, 2019
@data-sync-user data-sync-user changed the title [Bug]No fill from clipboard for a link copied from imgur.com FNX2-17331 ⁃ [Bug]No fill from clipboard for a link copied from imgur.com Aug 4, 2020
@data-sync-user data-sync-user changed the title FNX2-17331 ⁃ [Bug]No fill from clipboard for a link copied from imgur.com FNX3-15748 ⁃ [Bug]No fill from clipboard for a link copied from imgur.com Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-15748 ⁃ [Bug]No fill from clipboard for a link copied from imgur.com FNX-472 ⁃ [Bug]No fill from clipboard for a link copied from imgur.com Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-472 ⁃ [Bug]No fill from clipboard for a link copied from imgur.com [Bug]No fill from clipboard for a link copied from imgur.com May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
b:web-content Issues with websites. Check to see if the issue is GV or WebCompat too 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified needs:investigation P2 Upcoming release
Projects
None yet
Development

No branches or pull requests

8 participants