Skip to content
This repository was archived by the owner on Feb 20, 2023. It is now read-only.

For #1695 - Detect HTML mime type for clipboard URL #6612

Merged
merged 8 commits into from
Nov 15, 2019

Conversation

vespertineSiren
Copy link
Contributor


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

Screenshot_20191114-222532

I think this should be complete, @ekager .

@firefoxci-taskcluster
Copy link

No Taskcluster jobs started for this pull request
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

Copy link
Contributor

@NotWoods NotWoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start, congratulations on your first PR here!

vespertineSiren and others added 2 commits November 15, 2019 10:42
Co-Authored-By: Tiger Oakes <contact@tigeroakes.com>
Remove log import
Remove test comments
Co-Authored-By: Emily Kager <emilykager@gmail.com>
@ekager ekager changed the title For #1695 - Detect HTML mime type for clipboard URL For #1695 - Detect HTML mime type for clipboard URL 📋 Nov 15, 2019
@ekager
Copy link
Contributor

ekager commented Nov 15, 2019

ktlint is failing with

> Task :ktlint
[task 2019-11-15T19:10:40.886Z] /builds/worker/checkouts/src/app/src/main/java/org/mozilla/fenix/utils/ClipboardHandler.kt:27:1: Unexpected blank line(s) before "}"
[task 2019-11-15T19:10:41.286Z] /builds/worker/checkouts/src/app/src/test/java/org/mozilla/fenix/utils/ClipboardHandlerTest.kt:59:32: Missing spacing before "{"
[task 2019-11-15T19:10:41.286Z] /builds/worker/checkouts/src/app/src/test/java/org/mozilla/fenix/utils/ClipboardHandlerTest.kt:65:1: Unexpected blank line(s) before "}"

@ekager
Copy link
Contributor

ekager commented Nov 15, 2019

You can autoformat in the files it's unhappy with with Code -> Reformat Code so it will be happy
You can also run ktlint locally with Gradle -> Verification -> ktlint
or ./gradlew ktlint in the terminal

@codecov-io
Copy link

codecov-io commented Nov 15, 2019

Codecov Report

Merging #6612 into master will decrease coverage by 0.25%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6612      +/-   ##
============================================
- Coverage      17.1%   16.84%   -0.26%     
+ Complexity      362      352      -10     
============================================
  Files           272      271       -1     
  Lines         10687    10620      -67     
  Branches       1486     1473      -13     
============================================
- Hits           1828     1789      -39     
+ Misses         8708     8684      -24     
+ Partials        151      147       -4
Impacted Files Coverage Δ Complexity Δ
...n/java/org/mozilla/fenix/utils/ClipboardHandler.kt 73.33% <77.77%> (+4.1%) 14 <7> (+3) ⬆️
...main/java/org/mozilla/fenix/share/ShareFragment.kt 1.06% <0%> (-1.88%) 0% <0%> (ø)
...org/mozilla/fenix/components/BackgroundServices.kt 45.63% <0%> (-0.74%) 4% <0%> (ø)
...pp/src/main/java/org/mozilla/fenix/FeatureFlags.kt 100% <0%> (ø) 2% <0%> (ø) ⬇️
...ozilla/fenix/share/listadapters/AppShareAdapter.kt 71.42% <0%> (ø) 3% <0%> (ø) ⬇️
...a/org/mozilla/fenix/browser/BaseBrowserFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
.../java/org/mozilla/fenix/browser/BrowserFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...lla/fenix/customtabs/ExternalAppBrowserFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...mozilla/fenix/logins/SavedLoginSiteInfoFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ain/java/org/mozilla/fenix/share/ShareCloseView.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddd4843...9ffb284. Read the comment docs.

@ekager ekager changed the title For #1695 - Detect HTML mime type for clipboard URL 📋 For #1695 - Detect HTML mime type for clipboard URL Nov 15, 2019
Copy link
Contributor

@ekager ekager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's merge it!

@ekager ekager merged commit 5eb5cdf into mozilla-mobile:master Nov 15, 2019
@vespertineSiren vespertineSiren deleted the clipboard_html_fix branch November 18, 2019 21:07
@vespertineSiren vespertineSiren restored the clipboard_html_fix branch November 18, 2019 21:08
@vespertineSiren vespertineSiren deleted the clipboard_html_fix branch November 18, 2019 22:47
vespertineSiren added a commit to vespertineSiren/fenix that referenced this pull request Nov 18, 2019
vespertineSiren added a commit to vespertineSiren/fenix that referenced this pull request Nov 18, 2019
vespertineSiren added a commit to vespertineSiren/fenix that referenced this pull request Nov 19, 2019
vespertineSiren added a commit to vespertineSiren/fenix that referenced this pull request Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants