-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #1695 - Detect HTML mime type for clipboard URL #6612
For #1695 - Detect HTML mime type for clipboard URL #6612
Conversation
No Taskcluster jobs started for this pull requestThe `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start, congratulations on your first PR here!
Co-Authored-By: Tiger Oakes <contact@tigeroakes.com>
Remove log import
app/src/test/java/org/mozilla/fenix/utils/ClipboardHandlerTest.kt
Outdated
Show resolved
Hide resolved
Remove test comments
Co-Authored-By: Emily Kager <emilykager@gmail.com>
|
You can autoformat in the files it's unhappy with with Code -> Reformat Code so it will be happy |
Codecov Report
@@ Coverage Diff @@
## master #6612 +/- ##
============================================
- Coverage 17.1% 16.84% -0.26%
+ Complexity 362 352 -10
============================================
Files 272 271 -1
Lines 10687 10620 -67
Branches 1486 1473 -13
============================================
- Hits 1828 1789 -39
+ Misses 8708 8684 -24
+ Partials 151 147 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Let's merge it!
Pull Request checklist
After merge
To download an APK when reviewing a PR:
I think this should be complete, @ekager .