Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Telemetry] Send an event when users open the settings menu #18856

Closed
7 tasks
tdsmith opened this issue Apr 7, 2021 · 3 comments
Closed
7 tasks

[Telemetry] Send an event when users open the settings menu #18856

tdsmith opened this issue Apr 7, 2021 · 3 comments
Assignees
Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:Settings Feature:Telemetry
Milestone

Comments

@tdsmith
Copy link
Contributor

tdsmith commented Apr 7, 2021

Description & Product Manager / Data Scientist User Story

In order to understand whether we can improve the effectiveness of each messaging surface we’re testing in the set-default experiment (#18796), we should understand how many people see our messages at all. This relates to the branch described in #18376.

As a data scientist, I want to know how often users view the settings menu. I would like to observe a Glean event each time users view the settings menu.

What questions will you answer with this data?

How many users will see, saw, or could have seen the message we will place on the settings menu?

Acceptance Criteria

  • ENG files a DS JIRA request outlining their methodology. Let's discuss in this ticket if you have any questions.
  • DS sign off on instrumentation methodology addressing product questions.
  • Event pings can be queried via re:dash
  • Event pings can be queried via amplitude
  • We are sending telemetry events for the actions listed in the requirements
  • We have documented the telemetry
  • We have asked a data steward to review the telemetry

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 7, 2021
@amedyne amedyne removed the needs:triage Issue needs triage label Apr 8, 2021
@mcarare mcarare self-assigned this Apr 12, 2021
@mcarare
Copy link
Contributor

mcarare commented Apr 12, 2021

@tdsmith There already is an event that tracks when the settings button is clicked from the browser menu implemented as requested here: #1024.

My question for you is if we should just add the event trigger to the menu from the new tab screen, or should we add an event for the settings screen being displayed. The difference would be that while we currently track actions in the menu that open the settings screen, the settings screen could be also displayed when going back from a sub-settings screen.

Which one of these counts would be more suitable for this experiment?

@mcarare mcarare added the E3 Estimation Point: average, 2 - 3 days label Apr 12, 2021
@tdsmith
Copy link
Contributor Author

tdsmith commented Apr 12, 2021

I think you're right that the browser_menu_action event has the coverage we need. Thanks!

@lobontiumira
Copy link

Verified as fixed on the 4/19 Nightly build with Google Pixel (Android 10).
Ping: ccdad38d-90d0-42a8-bfaa-f3cd10e12df3

{
          "category": "home_menu",
          "name": "settings_item_clicked",
          "timestamp": 3918
        }

Glean dashboard

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:Settings Feature:Telemetry
Projects
None yet
Development

No branches or pull requests

5 participants