Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Bug 1812188 - Renew/remove telemetry probes expiring in 112. #28709

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Bug 1812188 - Renew/remove telemetry probes expiring in 112. #28709

merged 2 commits into from
Jan 31, 2023

Conversation

kycn
Copy link
Contributor

@kycn kycn commented Jan 31, 2023

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Used by GitHub Actions.

@kycn
Copy link
Contributor Author

kycn commented Jan 31, 2023 •
edited
Loading

Request for Data Collection Renewal

Renew for 6 months

Total: 6
———
events.tab_view_changed:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • 118

  3. Why was the initial period of collection insufficient?

    • Important to understand how our tabs view is displayed to users

———
history.search_icon_tapped:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • 118

  3. Why was the initial period of collection insufficient?

    • New UI evaluating user behaviors

———
history.search_result_tapped:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • 118

  3. Why was the initial period of collection insufficient?

    • New UI evaluating user behaviors

———
progressive_web_app.homescreen_tap:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • 118

  3. Why was the initial period of collection insufficient?

    • Key PWA interaction

———
progressive_web_app.install_tap:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • 118

  3. Why was the initial period of collection insufficient?

    • Key PWA interaction

———
recent_searches.group_deleted:

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • 118

  3. Why was the initial period of collection insufficient?

    • Used to understand search behavior

———

@kycn kycn added the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Jan 31, 2023
@kycn
Copy link
Contributor Author

kycn commented Jan 31, 2023 •
edited
Loading

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • What percent of DAU have contile turned off?
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • This will help us understand usage patterns around the Contile feature
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • There are no other alternatives.

  1. Can current instrumentation answer these questions?
  • No.

  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

    Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.
Measurement Description Data Collection Category Tracking Bug #
customize_home.contile: User disables/enables the Contile feature Category 2 - interaction data #24467
  1. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.
  1. How long will this data be collected? Choose one of the following:
  • No expiry set
  1. What populations will you measure?
  • All channels, all locales, all countries

  1. If this data collection is default on, what is the opt-out mechanism for users?
  • Default Glean SDK opt-out mechanism.

  1. Please provide a general description of how you will analyze this data.
  • Glean and Amplitude.

  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Amplitude, and with mobile teams.

  1. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?
  • No third-party tools.

@kycn
Copy link
Contributor Author

kycn commented Jan 31, 2023

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • This data will help collect metrics about Contile top sites click and impression.
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • This information is needed to support business metrics for the Mozilla Tiles Service.
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • There are no other alternatives.

  1. Can current instrumentation answer these questions?
  • No.

  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

    Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.
Measurement Description Data Collection Category Tracking Bug #
context_id: A UUID that is unjoinable with other browser metrics. This ID will not be shared with AdM, only for internal uses. This ID is shared across all contextual services features. Category 4 - Highly Sensitive #23893
contile_tile_id: A unique identifier provided by the AdM for the sponsored TopSites tile Category 2 - Interaction data #23893
contile_advertiser: Advertiser brand for the sponsored TopSites tile Category 2 - Interaction data #23893
contile_reporting_url: The AdM reporting endpoint (impression_url for “impression” event, click_url for “click” event). Category 2 - Interaction data #23893
contile_impression: A user saw a Contile top site Category 2 - Interaction data #23893
contile_click: A user clicked a Contile top site Category 2 - Interaction data #23893
  1. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.
  1. How long will this data be collected? Choose one of the following:
  • No expiry set.
  1. What populations will you measure?
  • All channels, all locales, all countries

  1. If this data collection is default on, what is the opt-out mechanism for users?
  • Default Glean SDK opt-out mechanism.

  1. Please provide a general description of how you will analyze this data.
  • Glean and Amplitude.

  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Amplitude, and with mobile teams.

  1. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?
  • No third-party tools.

@kycn
Copy link
Contributor Author

kycn commented Jan 31, 2023 •
edited
Loading

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • This will help us understand user interaction with the settings option from the home menu and also count the number of times the settings screen is displayed.
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • Determine how many people interact with this option.
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • There are no other alternatives.

  1. Can current instrumentation answer these questions?
  • No.

  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

    Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.
Measurement Description Data Collection Category Tracking Bug #
home_menu.settings_item_clicked: User clicks on settings item in home menu default browser Category 2 - Interaction Data #18856
  1. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.
  1. How long will this data be collected? Choose one of the following:
  • No expiry set.
  1. What populations will you measure?
  • All channels, all locales, all countries

  1. If this data collection is default on, what is the opt-out mechanism for users?
  • Default Glean SDK opt-out mechanism.

  1. Please provide a general description of how you will analyze this data.
  • Glean and Amplitude.

  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Amplitude, and with mobile teams.

  1. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?
  • No third-party tools.

@kycn
Copy link
Contributor Author

kycn commented Jan 31, 2023

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • This will help us understand user interaction with the home screen, how many times components inside this screen are being visualized by users.
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • Determine how many people interact with this screen related to the number of times it is displayed.
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • There are no other alternatives.

  1. Can current instrumentation answer these questions?
  • No.

  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

    Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.
Measurement Description Data Collection Category Tracking Bug #
home_screen.home_screen_displayed: home screen has been displayed Category 2 - Interaction Data #18854
  1. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.
  1. How long will this data be collected? Choose one of the following:
  • No expiry set.
  1. What populations will you measure?
  • All channels, all locales, all countries

  1. If this data collection is default on, what is the opt-out mechanism for users?
  • Default Glean SDK opt-out mechanism.

  1. Please provide a general description of how you will analyze this data.
  • Glean and Amplitude.

  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Amplitude, and with mobile teams.

  1. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?
  • No third-party tools.

@kycn kycn marked this pull request as ready for review January 31, 2023 16:44
@kycn kycn requested review from a team as code owners January 31, 2023 16:44
@kycn kycn added needs:review PRs that need to be reviewed and removed pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on labels Jan 31, 2023
@kycn kycn requested a review from rocketsroger January 31, 2023 16:45
@rocketsroger
Copy link
Contributor

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1. What questions will you answer with this data?


* What percent of DAU have contile turned off?


2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?


* This will help us understand usage patterns around the Contile feature


3. What alternative methods did you consider to answer these questions? Why were they not sufficient?


* There are no other alternatives.


4. Can current instrumentation answer these questions?


* No.


5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.
   
   Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.

Measurement Description Data Collection Category Tracking Bug #
customize_home.contile: User disables/enables the Contile feature Category 2 - interaction data #24467

6. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.


* [https://dictionary.telemetry.mozilla.org/apps/fenix
  ](https://dictionary.telemetry.mozilla.org/apps/fenix%E2%80%A8)


7. How long will this data be collected? Choose one of the following:


* No expiry set


8. What populations will you measure?


* All channels, all locales, all countries


9. If this data collection is default on, what is the opt-out mechanism for users?


* Default Glean SDK opt-out mechanism.


10. Please provide a general description of how you will analyze this data.


* Glean and Amplitude.


11. Where do you intend to share the results of your analysis?


* Only on Glean, Amplitude, and with mobile teams.


12. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?


* No third-party tools.

Data Review

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the metrics.yaml file and the Glean Dictionary

  1. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, through the "Send Usage Data" preference in the application settings

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

Permanent, kbrosnan@mozilla.com will be monitoring the data

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction data

  1. Is the data collection request for default-on or default-off?

default-on

  1. Does the instrumentation include the addition of any new identifiers?

No

  1. Is the data collection covered by the existing Firefox privacy notice?

Yes

  1. Does the data collection use a third-party collection tool?

No

Result

data-review+

@rocketsroger
Copy link
Contributor

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1. What questions will you answer with this data?


* This data will help collect metrics about Contile top sites click and impression.


2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?


* This information is needed to support business metrics for the Mozilla Tiles Service.


3. What alternative methods did you consider to answer these questions? Why were they not sufficient?


* There are no other alternatives.


4. Can current instrumentation answer these questions?


* No.


5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.
   
   Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.

Measurement Description Data Collection Category Tracking Bug #
context_id: A UUID that is unjoinable with other browser metrics. This ID will not be shared with AdM, only for internal uses. This ID is shared across all contextual services features. Category 4 - Highly Sensitive #23893
contile_tile_id: A unique identifier provided by the AdM for the sponsored TopSites tile Category 2 - Interaction data #23893
contile_advertiser: Advertiser brand for the sponsored TopSites tile Category 2 - Interaction data #23893
contile_reporting_url: The AdM reporting endpoint (impression_url for “impression” event, click_url for “click” event). Category 2 - Interaction data #23893
contile_impression: A user saw a Contile top site Category 2 - Interaction data #23893
contile_click: A user clicked a Contile top site Category 2 - Interaction data #23893

6. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.


* [https://dictionary.telemetry.mozilla.org/apps/fenix
  ](https://dictionary.telemetry.mozilla.org/apps/fenix%E2%80%A8)


7. How long will this data be collected? Choose one of the following:


* No expiry set.


8. What populations will you measure?


* All channels, all locales, all countries


9. If this data collection is default on, what is the opt-out mechanism for users?


* Default Glean SDK opt-out mechanism.


10. Please provide a general description of how you will analyze this data.


* Glean and Amplitude.


11. Where do you intend to share the results of your analysis?


* Only on Glean, Amplitude, and with mobile teams.


12. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?


* No third-party tools.

Data Review

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the metrics.yaml file and the Glean Dictionary

  1. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, through the "Send Usage Data" preference in the application settings

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

Permanent, kbrosnan@mozilla.com will be monitoring the data

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2 and 4. The Category 4 here is for renewal thus no need to go through legal.

  1. Is the data collection request for default-on or default-off?

default-on

  1. Does the instrumentation include the addition of any new identifiers?

No

  1. Is the data collection covered by the existing Firefox privacy notice?

Yes

  1. Does the data collection use a third-party collection tool?

No

Result

data-review+

@rocketsroger
Copy link
Contributor

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1. What questions will you answer with this data?


* This will help us understand user interaction with the settings option from the home menu and also count the number of times the settings screen is displayed.


2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?


* Determine how many people interact with this option.


3. What alternative methods did you consider to answer these questions? Why were they not sufficient?


* There are no other alternatives.


4. Can current instrumentation answer these questions?


* No.


5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.
   
   Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.

Measurement Description Data Collection Category Tracking Bug #
home_menu.settings_item_clicked: User clicks on settings item in home menu default browser Category 2 - Interaction Data #18856

6. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.


* [https://dictionary.telemetry.mozilla.org/apps/fenix
  ](https://dictionary.telemetry.mozilla.org/apps/fenix%E2%80%A8)


7. How long will this data be collected? Choose one of the following:


* No expiry set.


8. What populations will you measure?


* All channels, all locales, all countries


9. If this data collection is default on, what is the opt-out mechanism for users?


* Default Glean SDK opt-out mechanism.


10. Please provide a general description of how you will analyze this data.


* Glean and Amplitude.


11. Where do you intend to share the results of your analysis?


* Only on Glean, Amplitude, and with mobile teams.


12. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?


* No third-party tools.

Data Review

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the metrics.yaml file and the Glean Dictionary

  1. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, through the "Send Usage Data" preference in the application settings

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

Permanent, kbrosnan@mozilla.com will be monitoring the data

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction data

  1. Is the data collection request for default-on or default-off?

default-on

  1. Does the instrumentation include the addition of any new identifiers?

No

  1. Is the data collection covered by the existing Firefox privacy notice?

Yes

  1. Does the data collection use a third-party collection tool?

No

Result

data-review+

@rocketsroger
Copy link
Contributor

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1. What questions will you answer with this data?


* This will help us understand user interaction with the home screen, how many times components inside this screen are being visualized by users.


2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?


* Determine how many people interact with this screen related to the number of times it is displayed.


3. What alternative methods did you consider to answer these questions? Why were they not sufficient?


* There are no other alternatives.


4. Can current instrumentation answer these questions?


* No.


5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.
   
   Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.

Measurement Description Data Collection Category Tracking Bug #
home_screen.home_screen_displayed: home screen has been displayed Category 2 - Interaction Data #18854

6. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.


* [https://dictionary.telemetry.mozilla.org/apps/fenix
  ](https://dictionary.telemetry.mozilla.org/apps/fenix%E2%80%A8)


7. How long will this data be collected? Choose one of the following:


* No expiry set.


8. What populations will you measure?


* All channels, all locales, all countries


9. If this data collection is default on, what is the opt-out mechanism for users?


* Default Glean SDK opt-out mechanism.


10. Please provide a general description of how you will analyze this data.


* Glean and Amplitude.


11. Where do you intend to share the results of your analysis?


* Only on Glean, Amplitude, and with mobile teams.


12. Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection?


* No third-party tools.

Data Review

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the metrics.yaml file and the Glean Dictionary

  1. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, through the "Send Usage Data" preference in the application settings

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

Permanent, kbrosnan@mozilla.com will be monitoring the data

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction data

  1. Is the data collection request for default-on or default-off?

default-on

  1. Does the instrumentation include the addition of any new identifiers?

No

  1. Is the data collection covered by the existing Firefox privacy notice?

Yes

  1. Does the data collection use a third-party collection tool?

No

Result

data-review+

@rocketsroger
Copy link
Contributor

Request for Data Collection Renewal

Renew for 6 months

Total: 6 ——— events.tab_view_changed:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Issue #19956: Add telemetry for tab view setting changes #19959 (comment)](https://github.com/mozilla-mobile/fenix/pull/19959#issuecomment-882539619)

2. When will this collection now expire?
   
   * 118

3. Why was the initial period of collection insufficient?
   
   * Important to understand how our tabs view is displayed to users

——— history.search_icon_tapped:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Close #23694: Add telemetry for history search #23695](https://github.com/mozilla-mobile/fenix/pull/23695)

2. When will this collection now expire?
   
   * 118

3. Why was the initial period of collection insufficient?
   
   * New UI evaluating user behaviors

——— history.search_result_tapped:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Close #23694: Add telemetry for history search #23695](https://github.com/mozilla-mobile/fenix/pull/23695)

2. When will this collection now expire?
   
   * 118

3. Why was the initial period of collection insufficient?
   
   * New UI evaluating user behaviors

——— progressive_web_app.homescreen_tap:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #10261: PWA Telemetry #11859](https://github.com/mozilla-mobile/fenix/pull/11859)

2. When will this collection now expire?
   
   * 118

3. Why was the initial period of collection insufficient?
   
   * Key PWA interaction

——— progressive_web_app.install_tap:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #10261: PWA Telemetry #11859](https://github.com/mozilla-mobile/fenix/pull/11859)

2. When will this collection now expire?
   
   * 118

3. Why was the initial period of collection insufficient?
   
   * Key PWA interaction

——— recent_searches.group_deleted:

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #22175: Telemetry for deleting a search term group from recent searches on home #22176 (comment)](https://github.com/mozilla-mobile/fenix/pull/22176#issuecomment-956421788)

2. When will this collection now expire?
   
   * 118

3. Why was the initial period of collection insufficient?
   
   * Used to understand search behavior

———

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

@rocketsroger rocketsroger added pr:approved PR that has been approved and removed needs:review PRs that need to be reviewed labels Jan 31, 2023
@kycn kycn added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed pr:approved PR that has been approved labels Jan 31, 2023
@mergify mergify bot merged commit 3579919 into mozilla-mobile:main Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rocketsroger rocketsroger rocketsroger approved these changes

Assignees
No one assigned
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kycn @rocketsroger