Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Persistent notification to close all private browsing tabs #2053

Closed
yoasif opened this issue Apr 25, 2019 · 8 comments
Closed

Persistent notification to close all private browsing tabs #2053

yoasif opened this issue Apr 25, 2019 · 8 comments
Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:PrivateBrowsing needs:strings Needs strings
Milestone

Comments

@yoasif
Copy link
Contributor

yoasif commented Apr 25, 2019

Why/User Benefit/User Problem

As a user, I would like to be able to quickly close all private browsing tabs in Fenix. This exists today in Kiwi Browser, and I could have sworn it existed in Focus previously.

Acceptance Criteria (how do I know when I’m done?)

User is able to swipe down in notification area and tap a notification that allows them to close all private browsing tabs.

┆Issue is synchronized with this Jira Task

@yoasif
Copy link
Contributor Author

yoasif commented Apr 26, 2019

Given the decision in #1788 (comment) I think that this feature is also not required.

It may be desirable for some, but there is a risk that it will be destructive to more people than desired, and it was presented as an alternative to the trash icon in the toolbar.

@kbrosnan kbrosnan added Feature:PrivateBrowsing feature request 🌟 New functionality and improvements labels Apr 26, 2019
@vesta0 vesta0 added the P2 Upcoming release label Apr 30, 2019
@vesta0 vesta0 added this to the Post-MVP Backlog milestone Apr 30, 2019
@buttercookie42
Copy link

How does private browsing handle OOM-kills at the moment? Fennec stores private tabs in memory using Android's savedInstanceState, so private tabs can still be recreated if Android OOM-kills the app while in background (but not if the user actively swiped the app away or otherwise explicitly killed/quit it).

If we don't want to do something comparable with Fenix, then a foreground notification together with an associated service would at least make Android more unlikely to kill the app unless the OS was desperately short of memory.
While private browsing tabs are intended to be ephemeral, OOM-kills seems a bit too random to me, especially on low-end devices.

@vesta0 vesta0 modified the milestones: Backlog, Q3 Feature Backlog Jul 2, 2019
@vesta0 vesta0 added could and removed P2 Upcoming release feature request 🌟 New functionality and improvements labels Jul 2, 2019
@vesta0 vesta0 added the needs:UX-feedback Needs UX Feedback label Jul 11, 2019
@lime124 lime124 removed the needs:UX-feedback Needs UX Feedback label Jul 23, 2019
@lime124
Copy link
Collaborator

lime124 commented Jul 23, 2019

removing the ux label - this is on our radar already as it's part of Q3 plans.

@vesta0 vesta0 modified the milestone: Feature Backlog Jul 26, 2019
@vesta0 vesta0 added E3 Estimation Point: average, 2 - 3 days should and removed could labels Aug 9, 2019
@buttercookie42
Copy link

or if the user swipes away our activity

That might actually be okay, wouldn't it (#3950 thinks so, too)? It would need a little more careful implementation than how Fennec currently works to always close the private session in that case (while swiping away the task for the browsing activity will likely always clear the savedInstanceState, it's not guaranteed to actually kill the app process if the app has any other activities open, a service running, etc.), but it would certainly at least correspond to an explicit user action to get rid of the Fenix activity for the moment.

OOM-kills are certainly a different matter, though. For that specifically there's also #2493 and #2387 is basically the same issue (the OS killing the app process in a way that the user doesn't control and/or expect).

@boek boek added this to the v1.4 milestone Aug 16, 2019
@liuche
Copy link
Contributor

liuche commented Aug 21, 2019

@AmyYLee since string freeze is today, do the mocks have the most updated strings?

Are the updated strings:

Firefox Preview (private)
Delete private tabs

And the buttons Open and Delete and Open

https://mozilla.invisionapp.com/share/DUTCUDLZ4MC#/screens

jyeontaek added a commit to jyeontaek/fenix that referenced this issue Aug 23, 2019
jyeontaek added a commit to jyeontaek/fenix that referenced this issue Aug 23, 2019
jyeontaek added a commit to jyeontaek/fenix that referenced this issue Aug 23, 2019
jyeontaek added a commit to jyeontaek/fenix that referenced this issue Aug 23, 2019
jyeontaek added a commit to jyeontaek/fenix that referenced this issue Aug 27, 2019
jyeontaek added a commit to jyeontaek/fenix that referenced this issue Aug 27, 2019
@jyeontaek jyeontaek added the eng:qa:needed QA Needed label Aug 28, 2019
@lobontiumira
Copy link

Verified on the latest Nightly build190829 (#12410626) with Motorola Moto G6 (Android 8) that the notification is persistent. If "Delete and open" is tapped, all private tabs are closed and the app is opened, if "Open" is tapped, the app opens without closing the opened private tabs.

Screenshot_20190829-175138

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Aug 29, 2019
@data-sync-user data-sync-user changed the title Persistent notification to close all private browsing tabs FNX3-16020 ⁃ Persistent notification to close all private browsing tabs Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-16020 ⁃ Persistent notification to close all private browsing tabs FNX-5421 ⁃ Persistent notification to close all private browsing tabs Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-5421 ⁃ Persistent notification to close all private browsing tabs Persistent notification to close all private browsing tabs May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:PrivateBrowsing needs:strings Needs strings
Projects
None yet
Development

No branches or pull requests