-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Persistent notification to close all private browsing tabs #2053
Comments
Given the decision in #1788 (comment) I think that this feature is also not required. It may be desirable for some, but there is a risk that it will be destructive to more people than desired, and it was presented as an alternative to the trash icon in the toolbar. |
How does private browsing handle OOM-kills at the moment? Fennec stores private tabs in memory using Android's savedInstanceState, so private tabs can still be recreated if Android OOM-kills the app while in background (but not if the user actively swiped the app away or otherwise explicitly killed/quit it). If we don't want to do something comparable with Fenix, then a foreground notification together with an associated service would at least make Android more unlikely to kill the app unless the OS was desperately short of memory. |
removing the ux label - this is on our radar already as it's part of Q3 plans. |
That might actually be okay, wouldn't it (#3950 thinks so, too)? It would need a little more careful implementation than how Fennec currently works to always close the private session in that case (while swiping away the task for the browsing activity will likely always clear the savedInstanceState, it's not guaranteed to actually kill the app process if the app has any other activities open, a service running, etc.), but it would certainly at least correspond to an explicit user action to get rid of the Fenix activity for the moment. OOM-kills are certainly a different matter, though. For that specifically there's also #2493 and #2387 is basically the same issue (the OS killing the app process in a way that the user doesn't control and/or expect). |
@AmyYLee since string freeze is today, do the mocks have the most updated strings? Are the updated strings:
And the buttons |
…vate browsing tabs
…vate browsing tabs
…vate browsing tabs
…vate browsing tabs
…vate browsing tabs
Why/User Benefit/User Problem
As a user, I would like to be able to quickly close all private browsing tabs in Fenix. This exists today in Kiwi Browser, and I could have sworn it existed in Focus previously.
Acceptance Criteria (how do I know when I’m done?)
User is able to swipe down in notification area and tap a notification that allows them to close all private browsing tabs.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: