Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #4658: Add private browsing mode telemetry #4968

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

jyeontaek
Copy link
Contributor

@jyeontaek jyeontaek commented Aug 27, 2019

This covers #2834 and #2053.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@jyeontaek
Copy link
Contributor Author

jyeontaek commented Aug 28, 2019

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • Which system notification options users are interacting with the most
  • Whether or not the garbage icon is discoverable and useful to users
  • If users are tapping on the garbage icon accidentally with the use of the "undo" option on the snack bar
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • Since Focus will be sunset, the initial data retrieved from Fenix users will help us understand if the private mode features are useful.
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • N/A (These are baseline metrics)
  1. Can current instrumentation answer these questions?
  • Currently there are no events to track this.
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.
  • All data is Category 2.
  1. How long will this data be collected?
  • Until 03/01/2020
  1. What populations will you measure?
  • All release, beta, and nightly users with telemetry enabled.
  1. Please provide a general description of how you will analyze this data.
  • Glean / Amplitude
  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Amplitude and with mobile teams.

@jyeontaek jyeontaek added the needs:data-review PR is awaiting a data review label Aug 28, 2019
@jyeontaek jyeontaek requested a review from boek August 28, 2019 21:27
@jyeontaek jyeontaek marked this pull request as ready for review August 28, 2019 21:27
@jyeontaek jyeontaek requested a review from a team as a code owner August 28, 2019 21:27
@boek
Copy link
Contributor

boek commented Aug 28, 2019

Data Review Form (to be filled by Data Stewards)

Instructions: Data Stewards will review a request for data collection and endorse responses to each question.

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
    Yes, with metrics.yaml and metrics.md

  2. Is there a control mechanism that allows the user to turn the data collection on and off?
    Yes, in the Fenix settings

  3. If the request is for permanent data collection, is there someone who will monitor the data over time?
    Has expiry, Fenix team will monitor

  4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
    All data is category 2.

  5. Is the data collection request for default-on or default-off?
    Default on

  6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
    No

  7. Is the data collection covered by the existing Firefox privacy notice?
    yes

  8. Does there need to be a check-in in the future to determine whether to renew the data?
    Has expiry. Fenix team will monitor

  9. Does the data collection use a third-party collection tool?
    No

@codecov-io
Copy link

codecov-io commented Aug 28, 2019

Codecov Report

Merging #4968 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #4968      +/-   ##
===========================================
- Coverage      7.99%   7.96%   -0.03%     
  Complexity      176     176              
===========================================
  Files           226     226              
  Lines          9123    9154      +31     
  Branches       1329    1336       +7     
===========================================
  Hits            729     729              
- Misses         8342    8373      +31     
  Partials         52      52
Impacted Files Coverage Δ Complexity Δ
...pp/src/main/java/org/mozilla/fenix/HomeActivity.kt 7.87% <ø> (ø) 7 <0> (ø) ⬇️
.../sessioncontrol/viewholders/TabHeaderViewHolder.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...va/org/mozilla/fenix/components/metrics/Metrics.kt 18.13% <0%> (-0.52%) 0 <0> (ø)
...la/fenix/components/metrics/GleanMetricsService.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...ozilla/fenix/session/SessionNotificationService.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
.../fenix/home/intent/NotificationsIntentProcessor.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...ug/java/org/mozilla/fenix/DebugFenixApplication.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 040a6ad...4050c0a. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs:data-review PR is awaiting a data review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants